Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/network-interfaces-systemd: fix IPv6 privacy extensions #107061

Merged
merged 1 commit into from Dec 17, 2020
Merged

nixos/network-interfaces-systemd: fix IPv6 privacy extensions #107061

merged 1 commit into from Dec 17, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 16, 2020 •
edited

networkd seems to be buggy with IPv6PrivacyExtensions=kernel being set,
and the addresses don't appear anymore. In fact, the corresponding
sysctl seems to be set to -1 again.

Ran the privacy test, it succeeds now, so it should unblock channels.

cc @FRidh

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from rnhmjoj December 16, 2020 20:38
@flokli flokli mentioned this pull request Dec 16, 2020
Closed
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Dec 16, 2020 •
edited

Should we open an issue upstream?

@flokli
Copy link
Contributor Author

flokli commented Dec 16, 2020 •
edited

Already done: systemd/systemd#18003

Edit: Also added it to the commit message.

@flokli
nixos/network-interfaces-systemd: fix IPv6 privacy extensions
e1a5006 
networkd seems to be buggy with IPv6PrivacyExtensions=kernel being set,
and the addresses don't appear anymore. In fact, the corresponding
sysctl seems to be set to -1 again.

Fixes NixOS#106858.
Upstream Issue: systemd/systemd#18003
@ghost
Copy link

ghost commented Dec 16, 2020 •
edited by ghost

Can we please make sure that systemd 247.1 is in master before the channels are unblocked? I would rather not get hundreds of users experiencing #106791 / systemd/systemd#17768.

@flokli
Copy link
Contributor Author

flokli commented Dec 16, 2020 •
edited

If this requires yet another rebuild anyways, we should also merge in the 247.2 bump which seems to include the changes archlinux cherry-picked: #106858 (comment)

@FRidh can you orchestrate these staging merges somehow? 247.1 was merged 3 days ago, but it's not in staging-next yet.

@FRidh FRidh self-assigned this Dec 17, 2020
@FRidh FRidh changed the base branch from master to staging December 17, 2020 06:29
@FRidh FRidh merged commit d349582 into NixOS:staging Dec 17, 2020
@vcunat
Copy link
Member

vcunat commented Dec 21, 2020

Can we please make sure that systemd 247.1 is in master before the channels are unblocked?

A down-side is that the lag is rather high – nixos-unstable channel is 12 days old at this moment (e9158ec) and it doesn't seem like we can manage to update it in the next couple days either. (unless breaking this "promise"... picking the fix to master would be easy)

@flokli flokli deleted the networkd-fix-ipv6-privacy branch December 21, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

Assignees

@FRidh FRidh

Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @rnhmjoj @vcunat @FRidh