Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dstat: 0.7.3 -> 0.7.4 #107040

Merged
merged 1 commit into from Jan 19, 2021
Merged

dstat: 0.7.3 -> 0.7.4 #107040

merged 1 commit into from Jan 19, 2021

Conversation

nagy
Copy link
Member

@nagy nagy commented Dec 16, 2020

Motivation for this change

Reduce the number of python2 dependent packages. I also needed to remove the python-wifi module since that is not available for python3 anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

r-burns
r-burns approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi: dstat-real/dstat#170. But until we drop or migrate to the endorsed fork, good to be dropping python2.

Result of nixpkgs-review pr 107040 run on x86_64-linux 1

1 package built:
  • dstat

@SuperSandro2000
Copy link
Member

@nagy please fix the merge conflict.

@nagy
Copy link
Member Author

nagy commented Jan 18, 2021

fixed

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107040 run on x86_64-linux 1

1 package built:
  • dstat

@SuperSandro2000 SuperSandro2000 merged commit 829a060 into NixOS:master Jan 19, 2021
@nagy nagy deleted the dstat-python3 branch January 19, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nagy @SuperSandro2000 @r-burns @Janik-Haag