Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk3: 3.24.23 -> 3.24.24 #107037

Merged
merged 1 commit into from Dec 17, 2020
Merged

gtk3: 3.24.23 -> 3.24.24 #107037

merged 1 commit into from Dec 17, 2020

Conversation

Emantor
Copy link
Member

@Emantor Emantor commented Dec 16, 2020

Motivation for this change

Remove an old patch. Includes support for upstream primary selection
protocol, fixing primary selection for sway on the master branch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Emantor
gtk3: 3.24.23 -> 3.24.24
31a4230 
Remove an old patch. Includes support for upstream primary selection
protocol, fixing primary selection for sway on the master branch.
jtojnar
jtojnar approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay:

Overview of Changes in GTK+ 3.24.24

  • GtkColorChooser:
    • Update the default color palette
  • GtkFontChooser:
    • Fix family-only mode to return regular style
  • GtkTreeView:
    • Don't set focus-on-click for header buttons
  • Accessibility:
    • Implement scrollSubstringTo
    • Add a11y support to GtkPlug/GtkSocket
  • Printing:
    • Allow the lpr backend to print pdf and ps files
  • Theme:
    • Update gesture graphics
    • Update HighContrast css
  • Wayland:
    • Support the primary-selection-unstable-v1 protocol
  • X11:
    • Fix a crash with parent-relative backgrounds
  • Broadway:
    • Set modifier state of scroll events
  • Build:
    • Fix pc file generation on NixOS
  • OS X:
    • Restore command-key bindings
  • Windows:
    • Fix meson build with epoxy subproject
  • Translation updates

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Dec 16, 2020
@FRidh FRidh merged commit 5c6ed7b into NixOS:staging Dec 17, 2020
@calbrecht
Copy link
Member

This also fixes copying into clipboard links via context menu and from address bar, that went broken with Firefox 83.0 on sway. https://bugzilla.mozilla.org/show_bug.cgi?id=1631061#c31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@doronbehar doronbehar Awaiting requested review from doronbehar

@LnL7 LnL7 Awaiting requested review from LnL7

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Emantor @calbrecht @jtojnar @FRidh