Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: 83 -> 84 #107041

Merged
merged 3 commits into from Dec 20, 2020
Merged

firefox: 83 -> 84 #107041

merged 3 commits into from Dec 20, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Dec 16, 2020 •
edited by mweinelt

Motivation for this change

Upstream release https://www.mozilla.org/en-US/firefox/84.0/releasenotes/

cc @taku0 @andir

Things done
  • Tested compilation and basic features on x86_64 with X11 + Pulseaudio
  • Tested compilation and basic features on x86_64 with Wayland
  • Tested compilation and basic features on x86_64 with Pipewire
  • Tested compilation and basic features on aarch64

@ofborg ofborg bot requested a review from edolstra December 16, 2020 17:05
@mweinelt mweinelt added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 16, 2020
@fabianhjr
Copy link
Member

This is the security issue fixed: https://www.mozilla.org/en-US/security/advisories/mfsa2020-54/#CVE-2020-16042

@mweinelt
Copy link
Member

Tested firefox-wayland on x86_64. Unfortunately pipewire stopped working for me with FF83 and as of yet still does not work.

@mweinelt mweinelt mentioned this pull request Dec 16, 2020
Merged
3 tasks
@mweinelt
Copy link
Member

Pipewire works after applying #106815. PTAL

@mweinelt
Copy link
Member

@GrahamcOfBorg test firefox

I hope this is fine.

vcunat
vcunat approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine (X + x86_64). OfBorg reports aarch64 tests as OK, too. I can't see why wait; it contains some security fixes.

@vcunat vcunat merged commit d649d77 into NixOS:master Dec 20, 2020
@ajs124 ajs124 deleted the upd/firefox branch December 20, 2020 18:56
vcunat added a commit that referenced this pull request Dec 21, 2020
@vcunat
Merge #107041: firefox: 83 -> 84 (security)
60cf1b4 
(cherry picked from commit d649d77)
I mainly re-tested the `firefox` attribute on 20.09,
but I also briefly tried -esr -bin and -beta-bin.
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @fabianhjr @mweinelt @vcunat