Feature: Show group name as part of the default vehicle name. #8307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
added
candidate: yes
|
I really like this. There is one thing my OCD triggers on ... but I am not sure it needs fixing: It is now called I am almost tempted to always add a |
TrueBrain
force-pushed
the
group-name
branch
from
a2c1eb8
to
74bb4d4
Compare
Only if the vehicle is member of a group and does not have a user defined name.
TrueBrain
force-pushed
the
group-name
branch
from
74bb4d4
to
9afbb99
Compare
|
Okay, this hit my OCD enough that I added a commit to change I made some minor changes to your patch:
Also rebased :) |
This is for consistency; most other objects add a # to indicate it is the Nth of that object, except for Trains / RVs / Ships / Aircrafts. This becomes painfully apparent with unnamed vehicles in groups, which do get a "#".
TrueBrain
force-pushed
the
group-name
branch
from
9afbb99
to
d1e328b
Compare
TrueBrain
approved these changes
Dec 15, 2020
|
@TrueBrain Okay, thank you. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only if the vehicle is member of a group and does not have a user defined name.
This patch is based on @KeldorKatarn's commit:
KeldorKatarn/OpenTTD_PatchPack@3f03ec47