Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] zfs: 0.8.5 -> 0.8.6 #106952

Merged
merged 1 commit into from Dec 16, 2020
Merged

[20.09] zfs: 0.8.5 -> 0.8.6 #106952

merged 1 commit into from Dec 16, 2020

Conversation

hmenke
Copy link
Member

@hmenke hmenke commented Dec 15, 2020

Motivation for this change

Just very few upstream bugfixes. Most notably:

  • Linux 5.10 compat: check_disk_change() removed
  • Linux 5.10 compat: frame.h renamed objtool.h
  • Increase Supported Linux Kernel to 5.9
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hmenke
Copy link
Member Author

hmenke commented Dec 15, 2020

This should probably be held off until the channel has been fixed.

@jonringer @Mic92

@hmenke
Copy link
Member Author

hmenke commented Dec 15, 2020

Result of nixpkgs-review pr 106952 1

3 packages marked as broken and skipped:
  • bareos
  • virt-manager-qt
  • virtmanager-qt
66 packages built:
  • ceph
  • ceph-client
  • collectd
  • collectd-data
  • docker-machine-kvm
  • docker-machine-kvm2
  • easysnap
  • gnome3.gnome-boxes
  • grub2
  • grub2_efi
  • grub2_pvgrub_image
  • grub2_xen
  • libceph
  • libguestfs
  • libguestfs-with-appliance
  • libvirt
  • libvirt-glib
  • libvirt_5_9_0
  • libvmi
  • linuxPackages-libre.zfs
  • linuxPackages.zfs
  • linuxPackages_4_14.zfs
  • linuxPackages_4_19.zfs
  • linuxPackages_4_4.zfs
  • linuxPackages_4_9.zfs
  • linuxPackages_5_8.zfs
  • linuxPackages_5_9.zfs
  • linuxPackages_hardened.zfs
  • linuxPackages_latest-libre.zfs
  • linuxPackages_latest_hardened.zfs
  • linuxPackages_latest_xen_dom0.zfs
  • linuxPackages_latest_xen_dom0_hardened.zfs
  • linuxPackages_testing_bcachefs.zfs
  • linuxPackages_xen_dom0.zfs
  • linuxPackages_xen_dom0_hardened.zfs
  • linuxPackages_zen.zfs
  • minikube
  • minishift
  • nixops
  • nixopsUnstable
  • nixops_1_6_1
  • ocamlPackages.ocaml_libvirt
  • os-prober
  • perl530Packages.SysVirt
  • perl532Packages.SysVirt
  • python27Packages.guestfs
  • python27Packages.libvirt
  • python37Packages.guestfs
  • python37Packages.libvirt
  • python38Packages.guestfs
  • python38Packages.libvirt
  • rubyPackages.ruby-libvirt
  • rubyPackages_2_5.ruby-libvirt
  • rubyPackages_2_7.ruby-libvirt
  • samba4Full
  • sanoid
  • terraform-full
  • terraform-provider-libvirt (terraform-providers.libvirt)
  • terraform_0_11-full
  • vagrant
  • virtmanager (virt-manager)
  • virt-top
  • virtviewer (virt-viewer)
  • virtlyst
  • zfs
  • zfstools

@hmenke
Copy link
Member Author

hmenke commented Dec 15, 2020

@ofborg test zfs

jonringer
jonringer approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
tests pass

@jonringer jonringer merged commit 81fad87 into NixOS:release-20.09 Dec 16, 2020
@hmenke hmenke deleted the zfs branch December 16, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hmenke @jonringer