Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/samba-wsdd: fix starting #107112

Merged
merged 1 commit into from Dec 20, 2020
Merged

nixos/samba-wsdd: fix starting #107112

merged 1 commit into from Dec 20, 2020

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Dec 17, 2020

Motivation for this change

After update libseccomp to v2.5.1 need allow AF_NETLINK address families

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin mentioned this pull request Dec 17, 2020
Closed
@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 20, 2020

cc @flokli @aanderse @Mic92

@flokli
Copy link
Contributor

flokli commented Dec 20, 2020

I can confirm nix-build nixos/tests/samba-wsdd.nix being broken in master currently, and fixed after this PR. Thanks for the PR!

@flokli flokli merged commit e45d900 into NixOS:master Dec 20, 2020
@Izorkin Izorkin deleted the samba-wsdd-fix branch December 20, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Izorkin @flokli