Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archivy: 0.9.3 -> 1.0.0 #107106

Merged
merged 1 commit into from Feb 8, 2021
Merged

archivy: 0.9.3 -> 1.0.0 #107106

merged 1 commit into from Feb 8, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Dec 17, 2020 •
edited

Motivation for this change

updated deps

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Dec 17, 2020

Result of nixpkgs-review pr 107106 1

1 package built:
  • archivy

@siraben siraben changed the title archivy: 0.9.3 -> 0.10.0 archivy: 0.9.3 -> 0.10.1 Dec 27, 2020
@siraben
Copy link
Member Author

siraben commented Dec 27, 2020

Result of nixpkgs-review pr 107106 run on x86_64-linux 1

1 package built:
  • archivy

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107106 run on x86_64-linux 1

1 package built:
  • archivy

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

archivy:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'beautifulsoup4 ==' doesn't match anything in file 'requirements.txt'

Please check the offending substituteInPlace for typos or changes in source.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107106 run on x86_64-darwin 1

1 package built:
  • archivy

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

archivy:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'beautifulsoup4 ==' doesn't match anything in file 'requirements.txt'

Please check the offending substituteInPlace for typos or changes in source.

@siraben siraben changed the title archivy: 0.9.3 -> 0.10.1 archivy: 0.9.3 -> 1.0.0 Feb 2, 2021
@siraben
Copy link
Member Author

siraben commented Feb 2, 2021

@SuperSandro2000 please review, now updating to 1.0.0

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107106 run on x86_64-darwin 1

1 package built:
  • archivy

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

archivy:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'watchdog ==' doesn't match anything in file 'requirements.txt'

Please check the offending substituteInPlace for typos or changes in source.

@SuperSandro2000

This comment has been minimized.

Sign in to view
1 similar comment
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107106 run on x86_64-linux 1

1 package built:
  • archivy

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

archivy:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'watchdog ==' doesn't match anything in file 'requirements.txt'

Please check the offending substituteInPlace for typos or changes in source.

@siraben
Copy link
Member Author

siraben commented Feb 6, 2021

@SuperSandro2000 unused substituteInPlace fixed

@SuperSandro2000 SuperSandro2000 merged commit 88d5adc into NixOS:master Feb 8, 2021
@siraben siraben deleted the archivy-0.10.0 branch February 8, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @SuperSandro2000