Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmodulemd: Enable darwin support. #107102

Merged
merged 1 commit into from Dec 19, 2020
Merged

Conversation

rb2k
Copy link
Contributor

@rb2k rb2k commented Dec 17, 2020

Motivation for this change

This already compiles fine, no changes necesssary.
I am currently working on getting DNF to compile on darwin (long story) and this is one of the less problematic dependencies :)

Example:

% /nix/store/svsyagf509zn9n00qc2nqja883vfbf5k-libmodulemd-2.9.2-bin/bin/modulemd-validator --help
Usage:
  modulemd-validator [OPTION…] FILES - Simple modulemd YAML validator

Help Options:
  -h, --help        Show help options

Application Options:
  --debug           Output debugging messages
  -q, --quiet       Print no output
  -v, --verbose     Be verbose
  -V, --version     Print version number, then exit
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rb2k
Copy link
Contributor Author

rb2k commented Dec 18, 2020

Result of nixpkgs-review pr 107102 run on x86_64-linux 1

@rb2k
Copy link
Contributor Author

rb2k commented Dec 18, 2020

Result of nixpkgs-review pr 107102 run on x86_64-darwin 1

4 packages built:
  • libmodulemd
  • python37Packages.libmodulemd
  • python38Packages.libmodulemd
  • python39Packages.libmodulemd

@flokli flokli merged commit 999f6ee into NixOS:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants