Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: f01f31737120
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: fa0d499dbfa5
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Dec 16, 2020

  1. nixos/users-groups: createHome: Ensure HOME permissions, fix description

    configuration.nix(1) states
    
        users.extraUsers.<name>.createHome
            [...] If [...] the home directory already exists but is not
            owned by the user, directory owner and group will be changed to
            match the user.
    
    i.e. ownership would change only if the user mismatched;  the code
    however ignores the owner, it is sufficient to enable `createHome`:
    
        if ($u->{createHome}) {
            make_path($u->{home}, { mode => 0700 }) if ! -e $u->{home};
            chown $u->{uid}, $u->{gid}, $u->{home};
        }
    
    Furthermore, permissions are ignored on already existing directories and
    therefore may allow others to read private data eventually.
    
    Given that createHome already acts as switch to not only create but
    effectively own the home directory, manage permissions in the same
    manner to ensure the intended default and cover all primary attributes.
    
    Avoid yet another configuration option to have administrators make a
    clear and simple choice between securely managing home directories
    and optionally defering management to own code (taking care of custom
    location, ownership, mode, extended attributes, etc.).
    
    While here, simplify and thereby fix misleading documentation.
    klemensn authored and andir committed Dec 16, 2020
    Copy the full SHA
    8833983 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Merge pull request #106995 from andir/ml2pr/PATCH-nixos-users-groups-…

    …createHome-Ensure-HOME-permissions-fix-description
    
    nixos/users-groups: createHome: Ensure HOME permissions, fix description
    andir committed Dec 17, 2020
    Copy the full SHA
    fa0d499 View commit details
    Browse the repository at this point in the history