Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purple-gowhatsapp: init at 0.4.1 #107109

Closed
wants to merge 3 commits into from
Closed

purple-gowhatsapp: init at 0.4.1 #107109

wants to merge 3 commits into from

Conversation

nullscm
Copy link

@nullscm nullscm commented Dec 17, 2020 •
edited

Motivation for this change

Additional Pidgin plugin which was missing.
Connect WhatsApp-Web with Pidgin via scanning the QR-Code.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nullscm
nullscm commented Dec 17, 2020
View reviewed changes
Copy link
Author

@nullscm nullscm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the Package to the top-level list.

@SuperSandro2000
Copy link
Member

@vldn-dev please fix the eval error.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft January 18, 2021 11:31
@nullscm
Copy link
Author

nullscm commented Jan 18, 2021

i'm just seeing an error that vldn-dev isn't a found maintainer.. or do i missunderstand?

@SuperSandro2000
Copy link
Member

i'm just seeing an error that vldn-dev isn't a found maintainer.. or do i missunderstand?

yeah. Please add yourself to the maintainers list according to the contribution guide.

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@nullscm nullscm closed this by deleting the head repository Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nullscm @SuperSandro2000