Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

woof: 2012-05-31 -> 2020-12-17 #107111

Merged
merged 1 commit into from Dec 30, 2020
Merged

woof: 2012-05-31 -> 2020-12-17 #107111

merged 1 commit into from Dec 30, 2020

Conversation

matthiasbeyer
Copy link
Contributor

Also, fetch from github and bring python3 into scope with it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
woof: 2012-05-31 -> 2020-12-17
0a47237 
Also, fetch from github and bring python3 into scope with it.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@WolfangAukang
Copy link
Contributor

WolfangAukang commented Dec 29, 2020 •
edited

Result of nixpkgs-review pr 107111 run on x86_64-linux 1

1 package built:
  • woof

Working for me and code LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/308

@thiagokokada
Copy link
Contributor

thiagokokada commented Dec 30, 2020 •
edited

Result of nixpkgs-review pr 107111 1

1 package built:
  • woof

Tested and seems to work fine (also, removing old Python 2 packages is always a plus).

@AndersonTorres AndersonTorres merged commit b09455c into NixOS:master Dec 30, 2020
@matthiasbeyer matthiasbeyer deleted the update-woof branch December 30, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@WolfangAukang WolfangAukang WolfangAukang approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthiasbeyer @WolfangAukang @nixos-discourse @thiagokokada @AndersonTorres