Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: remove console.extraTTYs option #107118

Merged
merged 1 commit into from Dec 18, 2020
Merged

console: remove console.extraTTYs option #107118

merged 1 commit into from Dec 18, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Dec 17, 2020

Motivation for this change

Fix issue #88085

Things done
  • Tested using nix-build -E '(import ./nixos { configuration = { console.extraTTYs = []; }; }).vm'
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj merged commit 9a5e66f into NixOS:master Dec 18, 2020
@jboyens
Copy link
Contributor

jboyens commented Dec 18, 2020 •
edited

I'm not sure, but I think this merge may have broken the manual

builder for '/nix/store/wiqqczkab46w5qy7z4mzba35zfc5ihj5-nixos-manual-combined.drv' failed with exit code 3; last 10 log lines:
  manual-combined.xml:89372: element link: validity error : IDREF attribute linkend references an unknown ID "opt-console.extraTTYs"
   89368       </listitem>
   89369            <listitem>
   89370              <para>
   89371           <literal>boot.extraTTYs</literal> renamed to
   89372           <link linkend="opt-console.extraTTYs">console.extraTTYs</link>
   89373               </para>
   89374       </listitem>

  manual-combined.xml fails to validate
error: --- Error ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ nix
1 dependencies of derivation '/nix/store/h1733b92xi0mm1r2d4jy5rhj7j6kvg6c-nixos-manpages.drv' failed to build

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 18, 2020

Oof, yes there is link to this option that needs to be removed. I'm on it.

@rnhmjoj rnhmjoj deleted the ttys branch July 10, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @jboyens