Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codechange: Switch to C++17 on all platforms. #8376

Merged
merged 3 commits into from Dec 14, 2020
Merged

Codechange: Switch to C++17 on all platforms. #8376

merged 3 commits into from Dec 14, 2020

Conversation

frosch123
Copy link
Member

No description provided.

@LordAro
Copy link
Member

LordAro commented Dec 13, 2020

Documentation needs updating too ;)

@TrueBrain
Copy link
Member

I was thinking that it might be wise to keep this for after 1.11 is branched, just so there is more time to make use of it etc :)

@TrueBrain TrueBrain added candidate: yes This Pull Request is a candidate for being merged size: trivial This Pull Request is trivial labels Dec 14, 2020
@frosch123
Copy link
Member Author

frosch123 commented Dec 14, 2020 •
edited

According to https://github.com/pybind/ snip python_example/issues/ snip 44#issuecomment snip -714842598 (found by @michicc ) all interesting parts of C++17 are broken on OSX <= 10.14.

The compile farm seems to use 10.15.

I have no idea why this should affect OSX users who do not compile themself.

TrueBrain
TrueBrain reviewed Dec 14, 2020
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@frosch123
Codechange: Apple LLVM fails to implement std::optional::value() also…
cf252b7 
… on pretty recent version. Use operator* instead.
TrueBrain
TrueBrain approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been trying to find a reason to deny this patch, but I cannot find one :(

@michicc michicc merged commit cc1679e into OpenTTD:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
candidate: yes This Pull Request is a candidate for being merged size: trivial This Pull Request is trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frosch123 @LordAro @TrueBrain @michicc