Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xpra: 4.0.2 -> 4.0.6, add update script #108969

Merged
merged 2 commits into from Jan 15, 2021
Merged

xpra: 4.0.2 -> 4.0.6, add update script #108969

merged 2 commits into from Jan 15, 2021

Conversation

bbjubjub2494
Copy link
Member

@bbjubjub2494 bbjubjub2494 commented Jan 10, 2021 •
edited

Motivation for this change

Packages should be kept up-to-date as much as possible. The update script piggybacks of the Debian repository index that upstream maintains in order to determine the latest version.

Things done

Add script, and use script to update the package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbjubjub2494
Copy link
Member Author

bbjubjub2494 commented Jan 10, 2021 •
edited

I am unable to run nixpkgs-review at the moment because I don't have access to jdk-8u261. (outdated, #108810)

EDIT: sort of

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/108969

1 package failed to build:
ib-controller

2 packages built:
run-scaled xpra

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108969 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • run-scaled

@bbjubjub2494
Copy link
Member Author

Changed the update script to analyze the directory listing page instead. @SuperSandro2000 do you think that's preferable?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108969 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • ib-controller: log was empty
2 packages built:
  • run-scaled
  • xpra

@SuperSandro2000
Copy link
Member

Changed the update script to analyze the directory listing page instead. @SuperSandro2000 do you think that's preferable?

Not sure if it can easily break but it should work for now.

@bbjubjub2494
Copy link
Member Author

Ready for full review.

ib-controller builds fine if you have the unfree /nix/store/g51h2dcwsmb5mahx6h6z7bvbj45n7ijy-jdk-8u271-linux-x64.tar.gz in store.

$ nix run nixpkgs#nixpkgs-review pr 108969
[...]

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/108969

3 packages built:
ib-controller run-scaled xpra

@SuperSandro2000 SuperSandro2000 changed the title xpra: add update script xpra: 4.0.2 -> 4.0.6, add update script Jan 15, 2021
@SuperSandro2000 SuperSandro2000 merged commit ebd2285 into NixOS:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbjubjub2494 @SuperSandro2000