Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Appcpm: 0.996 -> 0.997000 #108997

Merged
merged 1 commit into from Jan 11, 2021
Merged

perlPackages.Appcpm: 0.996 -> 0.997000 #108997

merged 1 commit into from Jan 11, 2021

Conversation

zakame
Copy link
Member

@zakame zakame commented Jan 11, 2021

Motivation for this change

https://metacpan.org/release/SKAJI/App-cpm-0.997000

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner January 11, 2021 03:28
stigtsp
stigtsp approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 108997 run on x86_64-linux 1

2 packages built:
  • perl530Packages.Appcpm
  • perl532Packages.Appcpm

@stigtsp stigtsp merged commit a67cfc0 into NixOS:master Jan 11, 2021
@zakame
Copy link
Member Author

zakame commented Jan 11, 2021

Thanks! 🎉

@zakame zakame deleted the updates/perl-App-cpm-0.997000 branch January 11, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zakame @stigtsp