Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uboot: allow bigger kernels to boot on raspberry pi #108975

Merged
1 commit merged into from Jan 11, 2021
Merged

uboot: allow bigger kernels to boot on raspberry pi #108975

1 commit merged into from Jan 11, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 10, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the title and commit message to something like uboot: allow bigger kernels to boot on raspberry pies

@ghost
Copy link
Author

ghost commented Jan 10, 2021

Can you change the title and commit message to something like uboot: allow bigger kernels to boot on raspberry pies

sure!

@ghost ghost changed the title uboot: add patch to fix #97064 uboot: allow bigger kernels to boot on raspberry pi … Jan 10, 2021
@ghost ghost changed the title uboot: allow bigger kernels to boot on raspberry pi … uboot: allow bigger kernels to boot on raspberry pi Jan 10, 2021
@blaggacao
Copy link
Contributor

blaggacao commented Jan 10, 2021

Sorry for being at risk of abusing your care for the commons, but I'm trying to use this PR as an overlay and I seem unable to get it to work...

I tried setting it buildUboot and what not...

Is there an easy way I'm just not seeing?

@ghost
Copy link
Author

ghost commented Jan 10, 2021

Sorry for being at risk of abusing your care for the commons, but I'm trying to use this PR as an overlay and I seem unable to get it to work...

I tried setting it buildUboot and what not...

Is there an easy way I'm just not seeing?

Try this:

final: prev: {
  ubootRaspberryPi3_64bit = prev.ubootRaspberryPi3_64bit.overrideAttrs (o: { patches = [ ../pkgs/misc/uboot/0001-configs-rpi-allow-for-bigger-kernels.patch ]; });
}

Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to judge if the values can be problematic, but at a glance it looks alright: they're all increased by 0x800000 (except the kernel), so they all moved up in unison.

@samueldr
Copy link
Member

Hi!

Nice work, may I ask you to also send this upstream? We've had a good success story with @lopsided98 for rockchip boards in the past:

(Though you'll also have to fix the comments if you send upstream.)

@ghost ghost merged commit a315a15 into NixOS:master Jan 11, 2021
@ghost
Copy link
Author

ghost commented Jan 11, 2021

I will try to send it upstream in the next few hours, although I'm not entirely sure if they'll accept it. After all where is the limit for kernel size? It will just keep getting bigger and bigger and the values will not be enough in a year.

@lopsided98
Copy link
Contributor

I submitted a similar patch for the RockPro64 and they accepted it, although I don't remember how much I increased it by.

@samueldr
Copy link
Member

samueldr commented Jan 11, 2021

They are understanding of "mainline defconfig Linux". They know it exists, and gets bigger.

Just to re-iterate, here is the patch @lopsided98 contributed, if you want to see the reception:

(Though it was reviewed by the Rockchip... maintainer? )

You might want to ask them their opinion about sizes, and what they think it should be increased to.

@ghost
Copy link
Author

ghost commented Jan 11, 2021

Meh, all of us didni't actually test it and the patch I committed was for 2021.01 and doesn't apply to 2020.10. I will fix it later.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants