New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uboot: allow bigger kernels to boot on raspberry pi #108975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the title and commit message to something like uboot: allow bigger kernels to boot on raspberry pies
sure! |
Sorry for being at risk of abusing your care for the commons, but I'm trying to use this PR as an overlay and I seem unable to get it to work... I tried setting it Is there an easy way I'm just not seeing? |
Try this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to judge if the values can be problematic, but at a glance it looks alright: they're all increased by 0x800000
(except the kernel), so they all moved up in unison.
Hi! Nice work, may I ask you to also send this upstream? We've had a good success story with @lopsided98 for rockchip boards in the past: (Though you'll also have to fix the comments if you send upstream.) |
I will try to send it upstream in the next few hours, although I'm not entirely sure if they'll accept it. After all where is the limit for kernel size? It will just keep getting bigger and bigger and the values will not be enough in a year. |
I submitted a similar patch for the RockPro64 and they accepted it, although I don't remember how much I increased it by. |
They are understanding of "mainline defconfig Linux". They know it exists, and gets bigger. Just to re-iterate, here is the patch @lopsided98 contributed, if you want to see the reception: (Though it was reviewed by the Rockchip... maintainer? ) You might want to ask them their opinion about sizes, and what they think it should be increased to. |
Meh, all of us didni't actually test it and the patch I committed was for 2021.01 and doesn't apply to 2020.10. I will fix it later. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)