Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x11/xorg: stdenv.lib -> lib in meta generator #108935

Merged
merged 2 commits into from Jan 10, 2021
Merged

x11/xorg: stdenv.lib -> lib in meta generator #108935

merged 2 commits into from Jan 10, 2021

Conversation

Profpatsch
Copy link
Member

The library does not depend on stdenv, that stdenv exposes lib is
an artifact of the ancient origins of nixpkgs.

I didn’t run the generator since it takes quite a while, but it should
be automatically done the next time somebody updates a package.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Profpatsch
x11/xorg: stdenv.lib -> lib in meta generator
e2bd9f5 
The library does not depend on stdenv, that stdenv exposes lib is
an artifact of the ancient origins of nixpkgs.

I didn’t run the generator since it takes quite a while, but it should
be automatically done the next time somebody updates a package.
@alyssais
Copy link
Member

I think the generator should be run to avoid confusing the next person who runs it.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 10, 2021

The library does not depend on stdenv, that stdenv exposes lib is
an artifact of the ancient origins of nixpkgs.

I've always wondered why it's exposed in two places.
Would it make sense to do this change treewide?

@TredwellGit
Copy link
Member

#108938

@Profpatsch
Copy link
Member Author

I ran the generator and added the change in a second commit.

@Profpatsch Profpatsch merged commit 66c01cf into NixOS:master Jan 10, 2021
@Profpatsch Profpatsch mentioned this pull request Jan 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais approved these changes

@siraben siraben siraben approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

@TredwellGit TredwellGit Awaiting requested review from TredwellGit

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Profpatsch @alyssais @rnhmjoj @TredwellGit @siraben