Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localization for principia(have some problem) #2857

Merged
merged 23 commits into from
Feb 3, 2021
Merged

localization for principia(have some problem) #2857

merged 23 commits into from
Feb 3, 2021

Conversation

CindyRIng
Copy link
Contributor

Every thing is done except this problem that some strings are hidden.
image

@pleroy
Copy link
Member

pleroy commented Jan 10, 2021

[Automated message from GitHub Pull Request Builder] Answer "ok to test" to trigger testing of this PR.

@CindyRIng
Copy link
Contributor Author

ok to test

Copy link
Member

@eggrobin eggrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this significant contribution; this looks very good overall.

As I foretold I will have many comments about naming; let’s do this one window at a time, I commented on the strings referenced in main_window.cs, I will look at the other ones later.

I also took a quick look at the translations themselves, and I have a question about the best way to translate some of the more obscure technical terms we use.

@@ -430,7 +429,7 @@ internal class MainWindow : VesselSupervisedWindowRenderer {
using (new UnityEngine.GUILayout.HorizontalScope()) {
UnityEngine.GUILayout.Label(text : label + ":",
options : GUILayoutWidth(6));
if (UnityEngine.GUILayout.Button(text : index == 0 ? "min" : "-",
if (UnityEngine.GUILayout.Button(text : index == 0 ? Localizer.Format("#Principia_MainMenu_PluginText_Min") : "-",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this code technically lives in the main window, it is a general-purpose selector, so let’s not use the MainWindow prefix here.

Principia_DiscreteSelector_Min.

@@ -444,7 +443,7 @@ internal class MainWindow : VesselSupervisedWindowRenderer {
style : Style.RightAligned(UnityEngine.GUI.skin.textArea),
options : GUILayoutWidth(3));
if (UnityEngine.GUILayout.Button(
text : index == array.Length - 1 ? "max" : "+",
text : index == array.Length - 1 ? Localizer.Format("#Principia_MainMenu_PluginText_Max = max") : "+",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Principia_DiscreteSelector_Max.

#Principia_OBTAnalyser_Resault_OBTElements = 平均轨道根数
#Principia_OBTAnalyser_Resault_SiderealPeriod = 经度平均周期
#Principia_OBTAnalyser_Resault_NodalPeriod = 纬度平均周期
#Principia_OBTAnalyser_Resault_AnomalisticPeriod = 近点平均周期
Copy link
Member

@eggrobin eggrobin Jan 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation of the English term anomalistic period appears to be 近点周期 (e.g., https://zh.wikipedia.org/wiki/%E8%BD%A8%E9%81%93%E5%91%A8%E6%9C%9F).

EDIT: On second thought « mean anomalistic period » does not make much sense; see the next comment below.

I am guessing your translation actually came from translating the very technical definition given in https://github.com/mockingbirdnest/Principia/wiki/Orbit-analysis#periods:

  • sidereal period became something like mean longitude period (though mean longitude should be translated as 平经度, not 经度平均)
  • nodal period became something like mean [argument of] latitude period (though mean argument of latitude should be translated as 平纬度幅角, not 纬度平均).
  • anomalistic period became something like mean anomaly period (though mean anomaly should be translated as 平近点角, not 近点平均).

There are actual technical terms (恒星周期, 近点周期, 交点周期), see, e.g., https://baike.baidu.com/item/人造地球卫星运行轨道#2-2, let’s use those.


Original confused comment:

However, this is indeed the mean anomalistic period, where mean is in the sense of mean elements 平根数, i.e., elements free of short-term variation (see, e.g., http://jdse.bit.edu.cn/fileSKTCXB/journal/article/sktcxb/2020/4/PDF/sktcxb-7-4-wangying.pdf: 现将根数的摄动变化按其性质分解成长期变化、长周期变化和短周期变化3部分,只包含长期变化和长周期变化的摄动解称为拟平均轨道根数,工程简称平根数。), and there is enough room to clarify that in the Chinese version, so doing it is a good idea.

I am unable to find references to the mean anomalistic period in the Chinese literature, however, when looking for other mean elements, the 平均 always appears to be a prefix:

  • for the mean mean anomaly (note: the first mean here is for mean elements, the second is part of the name of the element mean anomaly), I find references to 平均平近点角, e.g., here;
  • for the mean argument of perigee, I find references to 平均近地点幅角 in the same paper, but also 平均近地点角 in ITU recommendations.

Since this is the mean (anomalistic period), not the anomalistic (mean period), should this be 平均近点周期?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is indeed the mean anomalistic period

Actually on second thought « mean anomalistic period » feels wrong; there is only one kind of osculating period, as distinguishing the periods is something you can only do if you have some sort of perturbation theory—which largely amounts to having a mean element theory.

Let’s just use the names of the three kinds of periods without further qualification, thus
sidereal period: 恒星周期
anomalistic period: 近点周期
nodal period: 交点周期

Copy link
Member

@eggrobin eggrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented on all remaining identifiers; I will review the translations of technical terms once that is addressed.
Many of the technical translations need changes, but since the cfg file will completely change with the renamings, doing both at the same time would make it complicated to keep track of what has and hasn’t been done.

@mockingbirdnest mockingbirdnest deleted a comment from pleroy Jan 31, 2021
@pleroy pleroy added the LGTM label Feb 3, 2021
@eggrobin eggrobin merged commit 93c7ad5 into mockingbirdnest:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants