Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various: mark as broken or fix #108977

Merged
merged 3 commits into from Jan 12, 2021
Merged

various: mark as broken or fix #108977

merged 3 commits into from Jan 12, 2021

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Jan 10, 2021

Motivation for this change

This either marks as broken or fixes various packages which are failing in nixpkgs-review builds of #108741, which are also broken at HEAD.

  • mxnet: fix build since GCC10 stdenv bump by reverting to GCC9 to avoid linker errors (fix)
  • python3Packages.cliff: remove version constraint on PrettyTable, add which to checkInputs (fix)
  • python3Packages.tensorflow-probability: broken by a tensorflow upgrade, non-trivial to update (mark as broken)
  • python3Packages,optuna: broken by lapack/BLAS changes, as well as sklearn upgrade (mark as broken)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
Copy link
Contributor Author

lukegb commented Jan 10, 2021

@ofborg build mxnet python3Packages.cliff

cc maintainers of broken packages @costrouc @timokau

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 10, 2021 •
edited

I did a quick check to find a patch for mxnet but couldn't find one. Maybe I overlooked it.

python3Packages.cliff: remove version constraint on PrettyTable, add which to checkInputs (fix)

I am pretty sure I did that in some other PR already but we can also fix this with this PR.

@ofborg ofborg bot requested a review from costrouc January 10, 2021 23:29
@lukegb
Copy link
Contributor Author

lukegb commented Jan 11, 2021

Yeah, there's #106866 as well which I think fixes the cliff build, although the cliff tests seemed to work for me (and on OfBorg); cc @IvarWithoutBones

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 11, 2021
Closed
10 tasks
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108977 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • python37Packages.optuna
  • python38Packages.optuna
  • python39Packages.cliff
1 package failed to build and are new build failure:
  • python37Packages.cliff: log was empty
1 package built:
  • python38Packages.cliff

@timokau
Copy link
Member

timokau commented Jan 11, 2021

I agree that we should mark broken packages as broken. I haven't noticed that tensorflow-probability was broken since I haven't used it in a while. I probably will not use it in the near future either. Would you mind removing me from the maintainers list of that package as well?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108977 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • python37Packages.optuna
  • python38Packages.optuna
  • python39Packages.cliff
6 packages built:
  • mxnet
  • python37Packages.cliff
  • python37Packages.mxnet
  • python38Packages.cliff
  • python38Packages.mxnet
  • python39Packages.mxnet

@lukegb
Copy link
Contributor Author

lukegb commented Jan 11, 2021

I agree that we should mark broken packages as broken. I haven't noticed that tensorflow-probability was broken since I haven't used it in a while. I probably will not use it in the near future either. Would you mind removing me from the maintainers list of that package as well?

No worries, done.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108977 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • python37Packages.optuna
  • python38Packages.optuna
  • python39Packages.cliff
1 package failed to build and are new build failure:
  • python37Packages.cliff: log was empty
1 package built:
  • python38Packages.cliff

@lukegb
Copy link
Contributor Author

lukegb commented Jan 11, 2021

Ah, you fixed cliff in #108925. I'll pull that change out of the stack.

@lukegb
tensorflow-probability: mark as broken
4a90665 
This was broken by the Tensorflow version bump, and is non-trivial to
correct - it now depends on dm-tree, which requires some work to build
due to a C++ extension which appears to require Bazel to compile.
@lukegb
mxnet: switch to GCC 9
7d9d1c5 
mxnet currently doesn't compile under GCC 10 (linker failures).
@lukegb
python3Packages.optuna: mark as broken.
c045030 
This doesn't compile. It's also very out-of-date (over a year old), and
has been broken by various library upgrades as well.
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108977 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python37Packages.optuna
  • python38Packages.optuna
4 packages built:
  • mxnet
  • python37Packages.mxnet
  • python38Packages.mxnet
  • python39Packages.mxnet

@SuperSandro2000 SuperSandro2000 merged commit 8bf14d4 into NixOS:master Jan 12, 2021
simeoncarstens added a commit to simeoncarstens/nixpkgs that referenced this pull request Jan 19, 2022
@simeoncarstens
tensorflow-probability: 0.8 -> 0.15.0
85603b4 
tensorflow-probability 0.8 was broken and marked as such (in NixOS#108977)
because of a dependency on dm-tree, which seems not to have been
available.
Since dm-tree is now available in nixpkgs (NixOS#152971),
tensorflow-probability is easy to fix and to upgrade.
simeoncarstens added a commit to simeoncarstens/nixpkgs that referenced this pull request Jan 26, 2022
@simeoncarstens
python3Packages.tensorflow-probability: 0.8 -> 0.15.0
38aba23 
tensorflow-probability 0.8 was broken and marked as such (in NixOS#108977)
because of a dependency on dm-tree, which seems not to have been
available.
Since dm-tree is now available in nixpkgs (NixOS#152971),
tensorflow-probability is easy to fix and to upgrade.
@lukegb lukegb deleted the mark-as-broken branch December 5, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukegb @SuperSandro2000 @timokau