Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poedit: use gtk3 #108980

Merged
merged 1 commit into from Jan 12, 2021
Merged

poedit: use gtk3 #108980

merged 1 commit into from Jan 12, 2021

Conversation

nagy
Copy link
Member

@nagy nagy commented Jan 10, 2021

Motivation for this change

Instead of using the old gtk2, lets use gtk3.

Notify maintainers

@domenkozar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108980 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • poedit

@SuperSandro2000
Copy link
Member

@nagy please solve the merge conflict

@nagy
Copy link
Member Author

nagy commented Jan 11, 2021

merge resolved

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108980 run on x86_64-linux 1

1 package built:
  • poedit

@SuperSandro2000 SuperSandro2000 merged commit 5bbd3a6 into NixOS:master Jan 12, 2021
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108980 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • poedit

@nagy nagy deleted the poedit-gtk3 branch January 12, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants