New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: 19.03.4 -> 20.10.2 #108960
docker: 19.03.4 -> 20.10.2 #108960
Conversation
docker = docker_19_03; | ||
docker-edge = docker_19_03; | ||
docker = docker_20_10; | ||
docker-edge = docker_20_10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to move this to aliases.nix
file 🤔 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could change in the future when they start builds for 21.04.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least to me it seems they stopped with edge releases (can't find a reference for Docker for Linux, but it seems that what happened for Windows/macOS at least).
37fca40
to
198fd05
Compare
This should close #109156 |
Should we backport this or the 19.03.9 update? |
198fd05
to
21bc5bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this is awesome! I tested it on a GitLab CI runner and was able to run with systemd.enableUnifiedCgroupHierarchy = true;
just fine. Also with this release, docker respects the --iptables=false
build-time flag afaict, so this makes things easier for me as an nftables user.
This commit refactors the build process to handle Docker engine and CLI split.
21bc5bc
to
94c6f1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM 🐯
Shouldn’t somebody have checked this before merge? This commit broke the channel-blocking |
I'm sorry, you're right. I only did testing in a real-world scenario. Interestingly docker.passthru.tests on aarch64-linux succeeded in ofborg. I'll look into it. |
This broke the kubelet service from kubernetes:
|
Addressed in #111590 |
Motivation for this change
This PR updates Docker to 20.10.2, and refactors the build process to handle Docker engine and CLI split.
Also adds long waited CGroups v2 support.
Depends on #108959
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)