Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: simplify pkgs.stdenv.lib -> pkgs.lib #108970

Merged
merged 1 commit into from Jan 10, 2021

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Jan 10, 2021

Motivation for this change

#108834

I chose the special pkgs.stdenv.lib case, because there should be no issues with lib not being in scope.

The library does not depend on stdenv, that `stdenv` exposes `lib` is
an artifact of the ancient origins of nixpkgs.
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Let's merge as soon as ofborg is green.

@SuperSandro2000
Copy link
Member

As this is a no rebuild I am going to merge it before it gets a merge conflict.

@SuperSandro2000 SuperSandro2000 merged commit d085417 into NixOS:master Jan 10, 2021
@cole-h cole-h mentioned this pull request Jan 10, 2021
10 tasks
@Profpatsch
Copy link
Member

@xaverdh see also #108978 and the tracking issue in #108938

@xaverdh xaverdh deleted the pkgs-stdenv-lib branch January 17, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants