Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squashfsTools: unconditionally build with lz4Support #108936

Merged
merged 1 commit into from Jan 11, 2021
Merged

squashfsTools: unconditionally build with lz4Support #108936

merged 1 commit into from Jan 11, 2021

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jan 10, 2021 •
edited

Can't think of a reason to not enable that.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

51 packages built:
  • Sylk
  • _1password-gui
  • appimage-run
  • appimagekit
  • chrysalis
  • deltachat-electron
  • devdocs-desktop
  • diffoscope
  • distrobuilder
  • electronplayer
  • irccloud
  • jitsi-meet-electron
  • joplin-desktop
  • keeweb
  • ledger-live-desktop
  • lens
  • lunar-client
  • lxd
  • marktext
  • minetime
  • molotov
  • mycrypto
  • notable
  • nuclear
  • p3x-onenote
  • pcloud
  • plexamp
  • python37Packages.binwalk
  • python37Packages.binwalk-full
  • python38Packages.binwalk
  • python38Packages.binwalk-full
  • python39Packages.binwalk
  • python39Packages.binwalk-full
  • radicle-upstream
  • ripcord
  • runwayml
  • singularity
  • soulseekqt
  • spotify
  • spotify-unwrapped
  • spotifywm
  • squashfsTools
  • ssb-patchwork
  • standardnotes
  • station
  • timeular
  • tusk
  • unityhub
  • wootility
  • zettlr
  • zulip

@Atemu Atemu requested a review from joachifm January 10, 2021 11:19
@Atemu Atemu changed the base branch from master to staging January 10, 2021 11:20
@SuperSandro2000
Copy link
Member

I think so, too. #18628

@Atemu
squashfsTools: unconditionally build with lz4Support
579b25b 
Can't think of a reason to not enable that.
@Atemu Atemu changed the title squashfsTools: enable lz4Support by default squashfsTools: unconditionally build with lz4Support Jan 10, 2021
@ofborg ofborg bot requested a review from ruuda January 10, 2021 12:35
ruuda
ruuda approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@ruuda ruuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joachifm joachifm removed their request for review January 10, 2021 15:32
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108936 run on x86_64-linux 1

1 package built:
  • squashfsTools

@SuperSandro2000 SuperSandro2000 merged commit 0a9371b into NixOS:staging Jan 11, 2021
@Atemu Atemu deleted the squashfsTools-lz4Support branch November 26, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@ruuda ruuda ruuda approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Atemu @SuperSandro2000 @ruuda