Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: add nativeBuildInputs for extra build tools #108950

Closed
wants to merge 1 commit into from

Conversation

Kloenk
Copy link
Member

@Kloenk Kloenk commented Jan 10, 2021

Motivation for this change

Create a way to add extra BuildInputs into buildLinux, so linux forks which need extra tools to build linux can use those

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Kloenk
Copy link
Member Author

Kloenk commented Jan 10, 2021

I removed extraBuildInputs, as the probably are not needed, and renamed it to nativeBuildInputs

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 10, 2021

@ofborg eval

@SuperSandro2000
Copy link
Member

not sure why this fails.

@Kloenk
Copy link
Member Author

Kloenk commented Jan 11, 2021

rebased, so OfBorg no hopefully can eval

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 11, 2021

Rebasing makes no difference. I think staging eval is broken right now. Lets wait until that is resolved.

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@Artturin Artturin changed the title linux: add extraBuildInputs and extraNativeBuildInputs linux: add extraNativeBuildInputs Oct 16, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 16, 2021
@Artturin Artturin changed the title linux: add extraNativeBuildInputs linux: add nativeBuildInputs Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants