Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: add vim-closer #108949

Merged
merged 2 commits into from Jan 13, 2021
Merged

vim: add vim-closer #108949

merged 2 commits into from Jan 13, 2021

Conversation

onsails
Copy link
Contributor

@onsails onsails commented Jan 10, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vim-closer = super.vim-closer.overrideAttrs(old: {
patches = [
(substituteAll {
src = ./patches/vim-closer/fix-tag.patch;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a substituteInPlace or fetch an upstream patch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better yet, there's nothing nixos specific in this, please upstream this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for feedback, fixed

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108949 run on x86_64-darwin 1

1 package built:
  • spacevim

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108949 run on x86_64-linux 1

9 packages built:
  • spacevim
  • vimPlugins.deol-nvim
  • vimPlugins.nvcode-color-schemes-vim
  • vimPlugins.nvim-dap
  • vimPlugins.vim-closer
  • vimPlugins.vim-floaterm
  • vimPlugins.vim-lsp
  • vimPlugins.vimspector
  • vimPlugins.yats-vim

vim-closer = super.vim-closer.overrideAttrs(old: {
dependencies = with super; [ vim-misc ];
patches = [
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(fetchpatch {
# Fix duplicate tag in doc
(fetchpatch {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@SuperSandro2000
Copy link
Member

hash mismatch in fixed-output derivation '/nix/store/1jmj0qzwai9prjrm0hg6cvqad58caa65-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch':
  wanted: sha256:0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9
  got:    sha256:065q30d913fm3pc7r5y53wmnb7q7bhv21qxavm65bkb91242d409
cannot build derivation '/nix/store/j0fh8ykvja3ik6cnf0q3n2wkszh3zwfb-vimplugin-vim-closer-2020-10-24.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/srr39xzn69w98zniwcam584h4ck1qzar-env.drv': 1 dependencies couldn't be built

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108949 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • vimPlugins.vim-closer: log was empty
8 packages built:
  • spacevim
  • vimPlugins.deol-nvim
  • vimPlugins.nvcode-color-schemes-vim
  • vimPlugins.nvim-dap
  • vimPlugins.vim-floaterm
  • vimPlugins.vim-lsp
  • vimPlugins.vimspector
  • vimPlugins.yats-vim

@onsails
Copy link
Contributor Author

onsails commented Jan 12, 2021

hash mismatch in fixed-output derivation '/nix/store/1jmj0qzwai9prjrm0hg6cvqad58caa65-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch':
  wanted: sha256:0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9
  got:    sha256:065q30d913fm3pc7r5y53wmnb7q7bhv21qxavm65bkb91242d409
cannot build derivation '/nix/store/j0fh8ykvja3ik6cnf0q3n2wkszh3zwfb-vimplugin-vim-closer-2020-10-24.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/srr39xzn69w98zniwcam584h4ck1qzar-env.drv': 1 dependencies couldn't be built

Sometimes I don't understand how to work with sha256 correctly.
I've obtained my hash via

❯ nix-prefetch-url https://github.com/rstacruz/vim-closer/commit/a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch
path is '/nix/store/q69cj0n5l7j7lcqdcj024p9s39dvwm5i-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch'
0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9

put it into derivation definition and then nix-build -A vimPlugins.vim-closer . executed correctly.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 13, 2021

Sometimes I don't understand how to work with sha256 correctly.
I've obtained my hash via

❯ nix-prefetch-url https://github.com/rstacruz/vim-closer/commit/a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch
path is '/nix/store/q69cj0n5l7j7lcqdcj024p9s39dvwm5i-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch'
0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9

put it into derivation definition and then nix-build -A vimPlugins.vim-closer . executed correctly.

That does not work because the patch is normalized and edited before being put in the nix store and because we have no input aware fetchers nothing fails on your end. This is the exact reason why I want input aware fetchers and not content addressable ones.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108949 run on x86_64-linux 1

9 packages built:
  • spacevim
  • vimPlugins.deol-nvim
  • vimPlugins.nvcode-color-schemes-vim
  • vimPlugins.nvim-dap
  • vimPlugins.vim-closer
  • vimPlugins.vim-floaterm
  • vimPlugins.vim-lsp
  • vimPlugins.vimspector
  • vimPlugins.yats-vim

@SuperSandro2000 SuperSandro2000 merged commit 8922b5d into NixOS:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants