New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim: add vim-closer #108949
vim: add vim-closer #108949
Conversation
pkgs/misc/vim-plugins/overrides.nix
Outdated
vim-closer = super.vim-closer.overrideAttrs(old: { | ||
patches = [ | ||
(substituteAll { | ||
src = ./patches/vim-closer/fix-tag.patch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a substituteInPlace or fetch an upstream patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better yet, there's nothing nixos specific in this, please upstream this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for feedback, fixed
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 9 packages built:
|
vim-closer = super.vim-closer.overrideAttrs(old: { | ||
dependencies = with super; [ vim-misc ]; | ||
patches = [ | ||
(fetchpatch { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(fetchpatch { | |
# Fix duplicate tag in doc | |
(fetchpatch { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package failed to build and are new build failure:
8 packages built:
|
Sometimes I don't understand how to work with sha256 correctly.
put it into derivation definition and then |
That does not work because the patch is normalized and edited before being put in the nix store and because we have no input aware fetchers nothing fails on your end. This is the exact reason why I want input aware fetchers and not content addressable ones. |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 9 packages built:
|
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)