Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/zfs: test stable with stable linuxPackages #108940

Merged
merged 1 commit into from Jan 14, 2021
Merged

tests/zfs: test stable with stable linuxPackages #108940

merged 1 commit into from Jan 14, 2021

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jan 10, 2021 •
edited

Only unstable is supposed to be compatible with linuxPackages_latest

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu
tests/zfs: test stable with stable linuxPackages
61c0e8e 
Only unstable is supposed to be compatible with linuxPackages_latest
@marvin-mk2 marvin-mk2 bot requested a review from kevincox January 14, 2021 18:50
@kevincox kevincox merged commit ddad87f into NixOS:master Jan 14, 2021
@Atemu Atemu deleted the zfs-test-with-stable-linuxPackages branch November 4, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincox kevincox kevincox approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Atemu @kevincox