nixos/plasma5: add kwinPackage option and kwin-lowlatency package #108987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is my attempt at #101041, since the original PR has not been updated in a while. It introduces an option
services.xserver.desktopManager.plasma5.kwinPackage
and a new packagekwin-lowlatency
.I've done some basic testing to make sure it works and have tried to make sure it adheres to style/naming conventions used across Nixpkgs and NixOS. However, I'm still new to contributing, and so any feedback (including nitpicks) would be appreciated.
Things to consider
kwin-lowlatency
is fairly popular, but recent changes to KWin might make it obsolete soon (or not, I have no idea). Other KWin forks (e.g. KWinFT) also exist, but I don't know how popular they are.kwin.package
or even justkwin
, butkwinPackage
seemed the most obvious to me.kwin-lowlatency
is updated when regularkwin
(and the rest of Plasma) is? I thought maybe it could be marked as broken if its version doesn't match the Plasma version, but I couldn't find a nice way to get the Plasma version.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)