Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

koules: init at 1.4 #108990

Merged
merged 1 commit into from Apr 8, 2022
Merged

koules: init at 1.4 #108990

merged 1 commit into from Apr 8, 2022

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Jan 10, 2021

Motivation for this change

koules is an old and fun arcade game based on the fundamental law of body attraction. It is available in Debian and Arch. This pull request adds it to nixpkgs.

I went through path hell for installing this correctly. :-) Even with Debian's patches, which introduce DESTDIR, it took me some time to get everything working (in particular the soundserver, which is a separate binary).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

siraben
siraben requested changes Jan 11, 2021
View reviewed changes
pkgs/games/koules/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108990 run on x86_64-linux 1

1 package built:
  • koules

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/359

rmcgibbo
rmcgibbo approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@rmcgibbo rmcgibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built on x86_64-linux. Runs fine. LGTM.

SuperSandro2000
SuperSandro2000 requested changes Mar 18, 2021
View reviewed changes
pkgs/games/koules/default.nix Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Oct 12, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 12, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 5, 2022
@iblech
Copy link
Contributor Author

iblech commented Apr 5, 2022

This pull request has undergone review, I just force-pushed a new commit to adapt to the new categories syntax for makeDesktopItem, and I believe it is fit for merging :-)

AndersonTorres
AndersonTorres approved these changes Apr 6, 2022
View reviewed changes
pkgs/games/koules/default.nix Outdated
'';

preBuild = ''
cp xkoules.6 xkoules.man
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line needed, if the line on installPhase copies the original one?

pkgs/games/koules/default.nix Outdated Show resolved Hide resolved
pkgs/games/koules/default.nix Outdated Show resolved Hide resolved
pkgs/games/koules/default.nix Outdated Show resolved Hide resolved
pkgs/games/koules/default.nix Show resolved Hide resolved
pkgs/games/koules/default.nix Outdated Show resolved Hide resolved
@iblech
Copy link
Contributor Author

iblech commented Apr 6, 2022

Thank you @AndersonTorres for your extensive review! I believe to have resolved all the issues you highlighted.

GitHub doesn't seem to allow me to comment directly on your question "Why is this line needed, if the line on installPhase copies the original one?" [Could not resolve to a node with the global id of 'MDE3OlB1bGxSZXF1ZXN0UmV2aWV3'.]. The answer is that because else the make phase fails (as alluded to in the comment of the build description). I wanted to keep the edits to the Makefile minimal, fixing the Makefile in this regard would also have been an option. Is it okay how it's done currently? :-)

AndersonTorres
AndersonTorres suggested changes Apr 7, 2022
View reviewed changes
pkgs/games/koules/default.nix Outdated Show resolved Hide resolved
@AndersonTorres
Copy link
Member

The answer is that because else the make phase fails (as alluded to in the comment of the build description). I wanted to keep the edits to the Makefile minimal, fixing the Makefile in this regard would also have been an option. Is it okay how it's done currently? :-)

Okay for now. The comment explains it well enough.

@AndersonTorres AndersonTorres merged commit c804ddb into NixOS:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siraben siraben siraben requested changes

@AndersonTorres AndersonTorres AndersonTorres requested changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@rmcgibbo rmcgibbo rmcgibbo approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iblech @SuperSandro2000 @nixos-discourse @AndersonTorres @rmcgibbo @siraben