Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.lens: 1.2.3 → 1.2.4 #108968

Merged
merged 1 commit into from Jan 13, 2021
Merged

ocamlPackages.lens: 1.2.3 → 1.2.4 #108968

merged 1 commit into from Jan 13, 2021

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jan 10, 2021

Motivation for this change

Support for OCaml ≥ 4.10
Use dune 2.

cc maintainer @kazcw

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hugolgst
Copy link
Member

hugolgst commented Jan 11, 2021 •
edited

It looks good to me.

Result of nixpkgs-review pr 108968 1

1 package built:
  • ocamlPackages.lens

@vbgl vbgl merged commit 2cc958d into NixOS:master Jan 13, 2021
@vbgl vbgl deleted the ocaml-lens-1.2.4 branch January 13, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugolgst hugolgst hugolgst approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @hugolgst