Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urn-timer: init at unstable-2017-08-20 #108953

Merged
merged 1 commit into from Jan 11, 2021
Merged

urn-timer: init at unstable-2017-08-20 #108953

merged 1 commit into from Jan 11, 2021

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jan 10, 2021 •
edited

Motivation for this change

There are no speedrunning timers in nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Without a split file the program will only show a file dialog. If you want to test this, use this file: https://github.com/3snowp7im/urn/blob/master/splits/sotn.json

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/creating-derivation-for-urn-a-split-tracker-for-speedrunning/8987/9

SuperSandro2000
SuperSandro2000 reviewed Jan 10, 2021
View reviewed changes
pkgs/tools/misc/urn-timer/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/urn-timer/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108953 run on x86_64-linux 1

1 package built:
  • urn-timer

@SuperSandro2000 SuperSandro2000 merged commit 0e99531 into NixOS:master Jan 11, 2021
@fgaz fgaz deleted the urn/init branch January 11, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @nixos-discourse @SuperSandro2000