Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sub-batch: init at 0.3.0 #108951

Merged
merged 1 commit into from Jan 11, 2021
Merged

sub-batch: init at 0.3.0 #108951

merged 1 commit into from Jan 11, 2021

Conversation

erictapen
Copy link
Member

Motivation for this change

Introduce sub-batch, a nice application for editing subtitles from the CLI.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen erictapen mentioned this pull request Jan 10, 2021
Closed
@fabaff
Copy link
Member

fabaff commented Jan 10, 2021

Result of nixpkgs-review pr 108951 1

1 package built:
  • sub-batch

@erictapen erictapen requested a review from fabaff January 10, 2021 20:58
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 11, 2021 •
edited

darwin:

these derivations will be built:
  /nix/store/y5jjywji0rl94rka042lgplxkxamgppc-source.drv
  /nix/store/9ilsz8cackl7ry89a3ylr2wlrs746f6h-sub-batch-0.3.0-vendor.tar.gz.drv
  /nix/store/g4fpfs3glx2fgw4kkphs75vivb9ld23n-sub-batch-0.3.0.drv
building '/nix/store/y5jjywji0rl94rka042lgplxkxamgppc-source.drv'...

trying https://github.com/kl/sub-batch/archive/631bd6e2d931f8a8e12798f4b6460739a14bcfff.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   154  100   154    0     0    252      0 --:--:-- --:--:-- --:--:--   251
100 29976    0 29976    0     0  29131      0 --:--:--  0:00:01 --:--:-- 29131
unpacking source archive /private/tmp/nix-build-source.drv-0/631bd6e2d931f8a8e12798f4b6460739a14bcfff.tar.gz
tar: sub-batch-631bd6e2d931f8a8e12798f4b6460739a14bcfff/tests/rename_invalid_utf8/\322\374\354\322\374\253\322\374\345\365\242\362\332\372\203\322\374\246\322\374\203\264+\203\264+\34201.srt: Cannot open: Illegal byte sequence
tar: Exiting with failure status due to previous errors
do not know how to unpack source archive /private/tmp/nix-build-source.drv-0/631bd6e2d931f8a8e12798f4b6460739a14bcfff.tar.gz
builder for '/nix/store/y5jjywji0rl94rka042lgplxkxamgppc-source.drv' failed with exit code 1
cannot build derivation '/nix/store/g4fpfs3glx2fgw4kkphs75vivb9ld23n-sub-batch-0.3.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/g4fpfs3glx2fgw4kkphs75vivb9ld23n-sub-batch-0.3.0.drv' failed

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108951 run on x86_64-darwin 1

1 package failed to build and are new build failure:
  • sub-batch: log was empty

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108951 run on x86_64-linux 1

1 package built:
  • sub-batch

@erictapen
Copy link
Member Author

Upstream doesn't indicate wether it's supposed to run on darwin, so I marked sub-batch as broken on darwin.

@SuperSandro2000 SuperSandro2000 merged commit 5ea5253 into NixOS:master Jan 11, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108951 run on x86_64-linux 1

1 package built:
  • sub-batch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @fabaff @SuperSandro2000