Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/systemd-boot: add typechecking #108952

Merged
merged 1 commit into from Mar 20, 2021
Merged

nixos/systemd-boot: add typechecking #108952

merged 1 commit into from Mar 20, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 10, 2021 •
edited

Motivation for this change

Type checking makes it easier to review/read the code and catch more error cases without having to test every possible path. Mypy here is only a built-time dependency and should not affect what people need to install to use the builder.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

thiagokokada
thiagokokada approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise LGTM. Not tested though.

@Mic92
Copy link
Member Author

Mic92 commented Jan 11, 2021

I planing on merging this in a few days.

@Mic92 Mic92 merged commit 1fc1440 into NixOS:master Mar 20, 2021
@Mic92 Mic92 deleted the systemd-builder branch March 20, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig aszlig approved these changes

@thiagokokada thiagokokada thiagokokada approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @aszlig @thiagokokada