Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fprintd: Use cfg.package instead of pkgs.fprintd #108962

Merged
merged 1 commit into from Jan 10, 2021
Merged

fprintd: Use cfg.package instead of pkgs.fprintd #108962

merged 1 commit into from Jan 10, 2021

Conversation

glittershark
Copy link
Member

Use the configured package for fprintd in services.dbus.packages and
environment.systemPackages rather than hardcoding pkgs.fprintd.

Motivation for this change

If I set services.fprint.package, I expect the package that I set to be installed rather than the one in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@glittershark
fprintd: Use cfg.package instead of pkgs.fprintd
ee12216 
Use the configured package for fprintd in services.dbus.packages and
environment.systemPackages rather than hardcoding pkgs.fprintd.
@adisbladis
Copy link
Member

@GrahamcOfBorg eval

@adisbladis adisbladis merged commit a7b1c82 into NixOS:master Jan 10, 2021
@glittershark glittershark deleted the fprintd-use-cfg branch January 11, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glittershark @adisbladis @thiagokokada