Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jellyfin-mpv-shim: 1.7.1 -> 1.8.1 #108989

Closed
wants to merge 3 commits into from
Closed

jellyfin-mpv-shim: 1.7.1 -> 1.8.1 #108989

wants to merge 3 commits into from

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Jan 10, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre
jellyfin-mpv-shim: remove shader pack nix package
0e74a4e 
The shader pack is included in the pypi build
SuperSandro2000
SuperSandro2000 reviewed Jan 11, 2021
View reviewed changes
pkgs/applications/video/jellyfin-mpv-shim/patches/series
@@ -0,0 +1,2 @@
disable-update-check.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is required at all. We have two patches here which could be easily replaced by substituteInPlace.

@ofborg ofborg bot requested a review from jojosch January 11, 2021 02:54
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108989 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • jellyfin-mpv-shim
3 packages built:
  • python37Packages.jellyfin-apiclient-python
  • python38Packages.jellyfin-apiclient-python
  • python39Packages.jellyfin-apiclient-python

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.jellyfin-apiclient-python:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.jellyfin-apiclient-python:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.jellyfin-apiclient-python:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

jojosch
jojosch reviewed Jan 15, 2021
View reviewed changes
Copy link
Member

@jojosch jojosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for updating the package. This update fell off my radar.

Playing videos works without problems (Jellyfin 10.7.0 on Sway).

The procedure regarding the patches should be decided by someone from the comitters.

@jojosch jojosch mentioned this pull request Mar 10, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojosch jojosch jojosch left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @SuperSandro2000 @jojosch