lensfun: update lensfun databases #108991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project has moved to GitHub.
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 2 packages marked as broken and skipped:
3 packages failed to build and are new build failures:
3 packages built:
|
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 5 packages marked as broken and skipped:
19 packages built:
|
flokli
force-pushed
the
lensfun-database
branch
from
b770263
to
1af7783
Compare
|
@SuperSandro2000 I addressed the review bits. |
The `[g-]lensfun-update-data` binaries can't really work on NixOS (as the database is immutable), and most other scripts seem to require the lensfun python bindings (which aren't installed either). Let's disable installing the helper scripts for now.
lensfun hasn't had a new release since quite some time, and the database updater doesn't work in NixOS (NixOS#99009). This replaces the database with a more recent snapshot during build, thus adding support for more recent camera models/lenses (as reported in NixOS#107304)
flokli
force-pushed
the
lensfun-database
branch
from
1af7783
to
9137be6
Compare
SuperSandro2000
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Built Darktable with this PR and verified Sony A7 III is visible in the list.
Closes #99009
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @expipiplus1 @cnnrro @cillianderoiste @flosse @mrVanDalo @danieldk @adisbladis