Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ufraw and the gimp plugin #108993

Merged
merged 1 commit into from Jan 13, 2021
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 11, 2021

Motivation for this change

#97946

commit 4e4c61d46e25c44cd6fc6ba2fbf5676dd2e03705
Author: Florian Klink <flokli@flokli.de>
Date:   Mon Jan 11 02:04:20 2021 +0100

    ufraw: remove
    
    This is broken and unmaintained. nufraw seems to be a drop-in
    alternative.
    
    Closes https://github.com/NixOS/nixpkgs/issues/97946.

commit 07e6b3bdb3ae32ec9a82c728cb25dffd75cf1736
Author: Florian Klink <flokli@flokli.de>
Date:   Mon Jan 11 02:03:35 2021 +0100

    gimpPlugins.nufraw: expose, remove broken gimpPlugins.ufraw

commit f09dc88cc727a83016c81f243179ff06e7878785
Author: Florian Klink <flokli@flokli.de>
Date:   Mon Jan 11 02:02:55 2021 +0100

    nufraw: provide gimp plugin
    
    This introduces a new "gimpPlugin" output, similar to how it was done in
    ufraw.

I didn't run the nufraw plugin, but it builds fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Comment on lines 25 to 26
assert withGimpPlugin -> gimp != null;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert withGimpPlugin -> gimp != null;

@austinbutler
Copy link
Member

Tried this out, it fails to load several different RAW files (Canon, Nikon, Panasonic).

/nix/store/3mr77qcnyarp9439xz87jfx0v691f9i5-gimp-with-plugins-2.10.22/lib/gimp/2.0/plug-ins/nufraw-gimp: fatal error: Segmentation fault

Loading directly, outside of GIMP, also fails.

[nix-shell:~/Documents/]$ nufraw ~/Pictures/P1000252.RW2
Segmentation fault (core dumped)

GIMP will default to using darktable if that's installed (I had to comment it out temporarily in my configuration.nix to test nufraw), and darktable works flawlessly, so I wonder if it's even worth exposing nufraw as a GIMP plugin. I think RawTherapee will also be used by GIMP for RAW.

@asbachb
Copy link
Contributor

asbachb commented Jan 11, 2021

I guess you're right. The main functionality seems to fail. On only tested with:

nufraw-batch --size 10 --out-type=png --noexif --output=preview.png --embedded-image P1250767.RW2

That works unless you're removing that --embedded-image flag. I guess when it's processing the raw footage the segmentation fault occurs.

@flokli
Copy link
Contributor Author

flokli commented Jan 12, 2021

So nufraw is currently entirely broken too?

In that case, I could trim that PR down, not include any nufraw changes and direct users to darktable?

@asbachb
Copy link
Contributor

asbachb commented Jan 12, 2021

@flokli Yes I think you should not link anything against nufraw for now.

@asbachb
Copy link
Contributor

asbachb commented Jan 12, 2021

I could get rid of the segmentation fault by applying the archlinux patch: https://github.com/asbachb/nixpkgs/tree/bugfix/nufraw

nufraw-batch now does not crash with an segfault but it creates just black images.

@asbachb
Copy link
Contributor

asbachb commented Jan 12, 2021

So lensfun seems somehow broken or incompatible. When adding flag --lensfun=none the preview is generated as expected.

@flokli flokli changed the title nufraw: expose gimp plugin, remove ufraw remove ufraw and the gimp plugin Jan 12, 2021
This is broken and unmaintained. nufraw seems to be a drop-in
alternative, but is currently broken (see
NixOS#108993 (comment)).

Using Darktable seems to be the reasonable choice for now.

Closes NixOS#97946.
@flokli
Copy link
Contributor Author

flokli commented Jan 12, 2021

I pushed a new version, now recommending Darktable, and not adding the nufraw changes.

The commit message still links to this PR, so someone interested in getting nufraw to work can pick it up.

@austinbutler
Copy link
Member

Result of nixpkgs-review pr 108993 run on x86_64-linux 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants