New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove ufraw and the gimp plugin #108993
remove ufraw and the gimp plugin #108993
Conversation
assert withGimpPlugin -> gimp != null; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert withGimpPlugin -> gimp != null; |
Tried this out, it fails to load several different RAW files (Canon, Nikon, Panasonic).
Loading directly, outside of GIMP, also fails.
GIMP will default to using |
I guess you're right. The main functionality seems to fail. On only tested with:
That works unless you're removing that |
So nufraw is currently entirely broken too? In that case, I could trim that PR down, not include any nufraw changes and direct users to darktable? |
@flokli Yes I think you should not link anything against |
I could get rid of the segmentation fault by applying the archlinux patch: https://github.com/asbachb/nixpkgs/tree/bugfix/nufraw
|
So |
This is broken and unmaintained. nufraw seems to be a drop-in alternative, but is currently broken (see NixOS#108993 (comment)). Using Darktable seems to be the reasonable choice for now. Closes NixOS#97946.
I pushed a new version, now recommending Darktable, and not adding the nufraw changes. The commit message still links to this PR, so someone interested in getting nufraw to work can pick it up. |
Result of |
Motivation for this change
#97946
I didn't run the nufraw plugin, but it builds fine.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)