Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deemix: init at 2.0.16 #108942

Closed
wants to merge 2 commits into from
Closed

deemix: init at 2.0.16 #108942

wants to merge 2 commits into from

Conversation

luc65r
Copy link
Contributor

@luc65r luc65r commented Jan 10, 2021

Motivation for this change

I will package deemix-pyweb

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented Feb 25, 2021

Result of nixpkgs-review pr 108942 run on x86_64-linux 1

6 packages built:
  • deemix (python38Packages.deemix)
  • python37Packages.deemix
  • python37Packages.deezer-py
  • python38Packages.deezer-py
  • python39Packages.deemix
  • python39Packages.deezer-py

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove platforms.all.

@luc65r luc65r changed the title deemix: init at 2.0.15 deemix: init at 2.0.16 Mar 1, 2021
eventlet
];

doCheck = false; # tcp: protocol not found
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
doCheck = false; # tcp: protocol not found
doCheck = false; # tcp: protocol not found
pythonImportsCheck = [ "deezer" ];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails the same way tests do:

File "/nix/store/rdgah0m8hww9pidmjbay2hjf81hnyzmj-python3.8-dnspython-1.16.0/lib/python3.8/site-packages/dns/rdtypes/IN/WKS.py", line 25, in <module>
    _proto_tcp = socket.getprotobyname('tcp')
OSError: protocol not found

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't happen. If this is not working the package wont work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it happens, and the package works.
Why shouldn't it be happening? The build is sandboxed, so it is not surprising it cannot have access to tcp connections.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing a package should not require a network connection.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it should not, but this is Python, and I guess imports can have side effects…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could try having /etc/protocols in the sandbox and see what happens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with this it fails with the same error when importing eventlet.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108942 run on x86_64-linux 1

6 packages built:
  • deemix (python38Packages.deemix)
  • python37Packages.deemix
  • python37Packages.deezer-py
  • python38Packages.deezer-py
  • python39Packages.deemix
  • python39Packages.deezer-py

@fabaff
Copy link
Member

fabaff commented Aug 19, 2021

Superseded by #132580

@fabaff fabaff closed this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants