Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samsung-a5y17lte: Init Samsung Galaxy A5 (2017) #278

Merged
merged 12 commits into from Jan 9, 2021

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Jan 9, 2021

This PR adds:

  • Exynos 7880 hardware description
  • Exynos-specific work
  • Samsung Galaxy A5 (2017) device support

The latter is done through the kernel source used for TWRP.

Additionally, patches were produced that:

  • Fixes initial color channel assignation for framebuffer
  • Force framebuffer on at start

Forcing the framebuffer on is weird. Though I say that, it is always weird with the current setup; it will not start in a predictable all-black state or similar, but rather it starts with a channel on, while the others are off. This ends up creating a weird blue "flash". It is not much of an issue, since in turn this gives us a working early framebuffer console.


Tip for someone trying to know if their kernel build is fine or not: deassemble a known working boot image (e.g. TWRP), and re-assemble it using pieces from your build. (Or the other way around.) By doing so, I was able to confirm that the kernel does boot properly, and work up to the initramfs. So in my particular case the init program was failing. In addition, it allowed the console ramoops to work in that bizarro TWRP, which allowed me to confirm the error.

@samueldr samueldr added the 4. type: port New device port label Jan 9, 2021
This fork is the one used by TWRP, is much more up-to-date with source
releases from the OEM, compared to the LineageOS fork.
@samueldr samueldr force-pushed the device/samsung-a5y17lte/init branch from ddf48ce to 8698680 Compare January 9, 2021 22:40
@samueldr samueldr merged commit 901eb37 into NixOS:master Jan 9, 2021
@samueldr samueldr deleted the device/samsung-a5y17lte/init branch January 9, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. type: port New device port
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant