Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yabridge,yabridgectl: init at 3.0.0 #108835

Merged
merged 4 commits into from Feb 17, 2021
Merged

yabridge,yabridgectl: init at 3.0.0 #108835

merged 4 commits into from Feb 17, 2021

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Jan 9, 2021 •
edited

Motivation for this change

Closes #108791

@thornycrackers I tried using Upright Piano through Reaper and everything seems to be working as expected:
upright-piano

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 9, 2021
View reviewed changes
pkgs/tools/audio/yabridge/default.nix Show resolved Hide resolved
pkgs/tools/audio/yabridge/default.nix Show resolved Hide resolved
pkgs/tools/audio/yabridge/default.nix Show resolved Hide resolved
pkgs/tools/audio/yabridge/default.nix Show resolved Hide resolved
pkgs/tools/audio/yabridge/default.nix Outdated Show resolved Hide resolved
pkgs/tools/audio/yabridge/default.nix Outdated Show resolved Hide resolved
pkgs/tools/audio/yabridge/default.nix Outdated Show resolved Hide resolved
pkgs/tools/audio/yabridgectl/libyabridge-from-nix-profiles.patch Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108835 run on x86_64-darwin 1

1 package built:
  • yabridgectl

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108835 run on x86_64-linux 1

2 packages built:
  • yabridge
  • yabridgectl

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108835 run on x86_64-linux 1

2 packages built:
  • yabridge
  • yabridgectl

@alpmestan
Copy link
Contributor

FWIW, yabridge 3.0 is out, with support for VST3, might be worth updating the PR to directly go to that version, since this hasn't landed yet.

@kira-bruneau
Copy link
Contributor Author

@alpmestan Yep, I already have an update that I'm testing right now, and I'll submit soon.

@kira-bruneau kira-bruneau changed the title yabridge,yabridgectl: init at 2.2.1 yabridge,yabridgectl: init at 3.0.0 Feb 14, 2021
@robbert-vdh
Copy link

Something that may also be good to be aware of is that yabridge (or any application compiled with wineg++ that directly or indirectly uses shobjidl.h) will not compile with Wine 6.2, or specifically with any Wine version after wine-mirror/wine@0c19e2e. I've reported the bug to Wine's bug tracker here.

@kira-bruneau kira-bruneau mentioned this pull request Feb 14, 2021
Merged
10 tasks
SuperSandro2000
SuperSandro2000 reviewed Feb 15, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit. Trying to build it later. Otherwise LGTM.

pkgs/tools/audio/yabridge/default.nix Outdated Show resolved Hide resolved
@kira-bruneau
Copy link
Contributor Author

Result of nixpkgs-review pr 108835 run on x86_64-linux 1

2 packages built:
  • yabridge
  • yabridgectl

@robbert-vdh
Copy link

I just added a tiny workaround for the compile errors caused by that regression in Wine 6.2 here: robbert-vdh/yabridge@c29bc59 It might be a good idea to compile from that commit instead of from the 3.0.0 tag! There have been no other changes since version 3.0.0.

@kira-bruneau
Copy link
Contributor Author

@robbert-vdh Since we're using the stable version of wine (6.0) to compile yabridge, I think it should be ok to leave it as it is.

@SuperSandro2000 SuperSandro2000 merged commit c340f37 into NixOS:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbert-vdh robbert-vdh robbert-vdh left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging Request: yabridge/yabridgectl
4 participants
@kira-bruneau @SuperSandro2000 @alpmestan @robbert-vdh