New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove: warning in cheat window #8538
Conversation
@@ -1837,7 +1837,6 @@ STR_ABANDON_SCENARIO_QUERY :{YELLOW}Are you | |||
# Cheat window | |||
STR_CHEATS :{WHITE}Cheats | |||
STR_CHEATS_TOOLTIP :{BLACK}Checkboxes indicate if you have used this cheat before | |||
STR_CHEATS_WARNING :{BLACK}Warning! You are about to betray your fellow competitors. Keep in mind that such a disgrace will be remembered for eternity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As STR_CHEATS_WARNING
is being removed in this PR, would it be great if you had a Update: Disuse of STR_CHEATS_WARNING
or a similar commit as the string is translated to multiple languages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have eints
for that. After this PR is merged, the next time he comes around, he removes the string from allll the other languages. We mere mortals don't have to spend time on that; we outsourced it :D
I disagree with removing the message entirely, though I do agree it could be reworded. Perhaps "Note that any usage of these settings will be recorded by the savegame" ? |
We talked a bit about this on IRC. Basically, I do not see what the value is in telling people about this behaviour, and I was even tempted to just completely remove it (not store if someone used cheats). But for debugging purposes it is kinda useful that the information is stored. So I guess? At least not in the same location and in the form it was done, as I basically didn't even notice the text, as my mind immediately dismissed it as "ads". It is funny how our brains are primed to skip parts of windows we expect carry no value :D I will see what I can do. |
72d150f
to
3cb1ab9
Compare
3cb1ab9
to
ad5d16b
Compare
Not sure how much work you want to put into this. But the GUI would probably be prettier, if you insert vertical space (WD_PAR_VSEP_NORMAL) over the first item. Can't remember whether the widgets support padding by themself. |
Although meant as a funny joke towards the player, our social standards have changed since 2004, and such "jokes" are no longer acceptable by the community as a whole. The only value of the message is that people are informed the information is stored in the savegame. This is mostly useful for us, developers, as some of those cheats can have side-effects which people report. While at it, styled the GUI a bit better, as the way the text was presented was odd.
ad5d16b
to
32dba83
Compare
Fixes #8034
Motivation / Problem
17 years later, and the joke has aged poorly.
Description
Although meant as a funny joke towards the player, our social
standards have changed since 2004, and such "jokes" are no
longer acceptable by the community as a whole.
It also serves absolutely no purpose, other than trying to be
funny. Let's keep the jokes to funny people, so we can concentrate
on a good game :)
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.