Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oxefmsynth: init at 1.3.5 #108859

Merged
merged 1 commit into from Apr 3, 2021
Merged

oxefmsynth: init at 1.3.5 #108859

merged 1 commit into from Apr 3, 2021

Conversation

hirenashah
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 9, 2021
View reviewed changes
pkgs/applications/audio/oxefmsynth/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/oxefmsynth/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/oxefmsynth/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/oxefmsynth/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/oxefmsynth/default.nix Outdated Show resolved Hide resolved
@hirenashah hirenashah changed the title oxefmsynth: init at v1.3.5 oxefmsynth: init at 1.3.5 Jan 9, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108859 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • oxefmsynth: log was empty

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

@hirenashah FTBFS with

make: *** No rule to make target 'install'.  Stop.

@SuperSandro2000 SuperSandro2000 merged commit cd2e10d into NixOS:master Apr 3, 2021
@hirenashah hirenashah deleted the oxefmsynth branch July 30, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmcgibbo rmcgibbo rmcgibbo left review comments

@sikmir sikmir sikmir left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@magnetophon magnetophon Awaiting requested review from magnetophon

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hirenashah @SuperSandro2000 @rmcgibbo @sikmir