Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchzip: fix commands following extraPostFetch #108887

Closed
wants to merge 1 commit into from
Closed

fetchzip: fix commands following extraPostFetch #108887

wants to merge 1 commit into from

Conversation

dbueno
Copy link
Contributor

@dbueno dbueno commented Jan 9, 2021 •
edited

If extraPostFetch contains a command without a trailing newline, the command will be concatenated with chmod. fetchFromBitbucket does this and it leads to the $out directory being removed by the source unpacking phase.

Motivation for this change

I want fetchFromBitbucket to not erase the $out directory.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dbueno
fetchzip: fix commands following extraPostFetch
1a64f98 
If extraPostFetch contains a command without a trailing newline, the
command will be concatenated with chmod. fetchFromBitbucket does this
and it leads to the $out directory being removed by the source unpacking
phase.
@oxij oxij mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: fetch 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbueno @SuperSandro2000