Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubyPackages.nokogiri: Fix overwrites for 1.11.1 #108924

Closed
wants to merge 1 commit into from
Closed

rubyPackages.nokogiri: Fix overwrites for 1.11.1 #108924

wants to merge 1 commit into from

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 10, 2021 •
edited

which are required for eg metasploit

Motivation for this change

#108878

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 10, 2021
Merged
10 tasks
@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108924 run on x86_64-linux 1

1 package built:
  • rubyPackages.nokogiri

@SuperSandro2000
Copy link
Member Author

/rebase-staging

@SuperSandro2000 @github-actions
rubyPackages.nokogiri: Fix overwrites for 1.11.1
12b8fc8 
which are required for eg metasploit
@github-actions github-actions bot changed the base branch from master to staging January 10, 2021 10:38
@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108924 run on x86_64-linux 1

1 package built:
  • rubyPackages.nokogiri

@marsam
Copy link
Contributor

marsam commented Jan 10, 2021

I think it should be fixed by abe3a18 (already in staging)

@SuperSandro2000
Copy link
Member Author

I think it should be fixed by abe3a18 (already in staging)

Didn't find this.

@SuperSandro2000 SuperSandro2000 deleted the nokogiri-1.11.1 branch January 10, 2021 19:22
@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 12, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: ruby 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @marsam