vulkan-loader: fix pkg-config include directory #108890

B4dM4n · 2021-01-09T22:30:42Z

Motivation for this change

With the last update the pkg-config file was changed to cmake variables, which made substituteInPlace ineffective.

Things done

SuperSandro2000 · 2021-01-10T01:34:57Z

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108890 run on x86_64-linux 1

1 package built:

vulkan-loader

Ralith · 2021-01-10T05:06:33Z

Thanks! Unfortunately I don't know anything about the cmake infrastructure involved here so I'm not a great reviewer. Wouldn't setting CMAKE_INSTALL_INCLUDEDIR make it try to write to it?

SuperSandro2000 · 2021-01-10T06:50:53Z

Result of nixpkgs-review pr 108890 run on x86_64-darwin 1

9 packages marked as broken and skipped:

firefox-esr-78-unwrapped
firefox-unwrapped
firefoxPackages.firefox
firefoxPackages.firefox-esr-78
haskellPackages.VulkanMemoryAllocator
haskellPackages.vulkan
haskellPackages.vulkan-utils
libplacebo
xulrunner

B4dM4n · 2021-01-10T14:31:27Z

Thanks! Unfortunately I don't know anything about the cmake infrastructure involved here so I'm not a great reviewer. Wouldn't setting CMAKE_INSTALL_INCLUDEDIR make it try to write to it?

Yes, this could happen.

When vulkan-loader provides it's own headers in the future, it would try to install them into the vulkan-headers path, which will fail due to the folder being read only. This failure would be detected during build time and can be handled accordingly.

I prefer this behavior over a silently failing substituteInPlace.

jtojnar · 2021-01-22T10:02:05Z

pkgs/development/libraries/vulkan-loader/default.nix

-      --replace 'libdir=''${exec_prefix}/@CMAKE_INSTALL_LIBDIR@' 'libdir=@CMAKE_INSTALL_LIBDIR@'
-  '';
+  # Set CMAKE_INSTALL_INCLUDEDIR to the vulkan-headers directory
+  include = vulkan-headers;


This feels like a hack, overriding the variables related to output. Would not setting cmakeFlags = [ "-DCMAKE_INSTALL_INCLUDEDIR=${vulkan-headers}" ]; be enough.

You are right, setting cmakeFlags is enough to change the install path. I have tried to do this the first time, but I must have checked the vulkan.pc in a outdated result-dev link or something, because it didn't work for me. Therefore I came up with this hack.

I will update the PR.

With the last update the pkg-config file was changed to cmake variables, which made substituteInPlace ineffective. Fixes NixOS#108766

B4dM4n · 2021-01-22T11:31:52Z

I updated the PR to not use the output "hack" anymore, but simply set CMAKE_INSTALL_INCLUDEDIR.

I also included a simple installCheckPhase to ensure the vulkan-headers include directory is actuall present in the vulkan.pc file.

jtojnar · 2021-01-22T12:56:59Z

Looks good, thanks.

Slabity · 2021-02-01T19:54:39Z

This change seems to have broken vulkan-loader on my system. The added check is the following:

grep -q "${vulkan-headers}/include" $dev/lib/pkgconfig/vulkan.pc

But vulkan.pc contains the following:

prefix=/nix/store/rmsyd1xzrg4vvmq7vx6gaa5phiqb6lfd-vulkan-loader-1.2.162.0
exec_prefix=/nix/store/rmsyd1xzrg4vvmq7vx6gaa5phiqb6lfd-vulkan-loader-1.2.162.0
libdir=/nix/store/rmsyd1xzrg4vvmq7vx6gaa5phiqb6lfd-vulkan-loader-1.2.162.0/lib
includedir=/nix/store/xb9k68zm2s1bm3p9ybmw559awzcx5b13-vulkan-loader-1.2.162.0-dev/include

Name: Vulkan-Loader
Description: Vulkan Loader
Version: 1.2.162
Libs: -L${libdir} -lvulkan
Libs.private:  -lstdc++ -lm -lgcc_s -lgcc -lc -lgcc_s -lgcc
Cflags: -I${includedir}

There is no reference to ${vulkan-headers}/include in the pkgconfig file and thus the new check fails.

Is the added CMAKE_INSTALL_INCLUDEDIR suppose to change the path of the includedir in the pkgconfig file?

jtojnar · 2021-02-01T20:01:56Z

Yes, the CMAKE_INSTALL_INCLUDEDIR is supposed to change the path of the includedir in the pkgconfig file. And it does that for me on master (3c88f38).

Slabity · 2021-02-01T20:09:39Z

Really? My build-attempt from master seems to fail:

$ git clone https://github.com/NixOS/nixpkgs.git
Cloning into 'nixpkgs'...
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 2299211 (delta 0), reused 1 (delta 0), pack-reused 2299205
Receiving objects: 100% (2299211/2299211), 1.30 GiB | 28.68 MiB/s, done.
Resolving deltas: 100% (1570018/1570018), done.

$ cd nixpkgs

$ git checkout master
Already on 'master'
Your branch is up to date with 'origin/master'.

$ nix-build . -A vulkan-loader
this derivation will be built:
  /nix/store/gxgpbskj0c8sj162bv6kwxy90rpna4jk-vulkan-loader-1.2.162.0.drv
building '/nix/store/gxgpbskj0c8sj162bv6kwxy90rpna4jk-vulkan-loader-1.2.162.0.drv'...
unpacking sources
unpacking source archive /nix/store/sdh237c6x2g4zzdxl67clxajp61qqix6-source
source root is source
patching sources
configuring
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/share/doc/Vulkan-Loader -DCMAKE_INSTALL_INFODIR=/nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev/include -DCMAKE_INSTALL_SBINDIR=/nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/rqfgki7ck1bxqhk3hd7wziqhahjadfbj-binutils-2.35.1/bin/strip -DCMAKE_RANLIB=/nix/store/rqfgki7ck1bxqhk3hd7wziqhahjadfbj-binutils-2.35.1/bin/ranlib -DCMAKE_AR=/nix/store/rqfgki7ck1bxqhk3hd7wziqhahjadfbj-binutils-2.35.1/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0 -DSYSCONFDIR=/run/opengl-driver/share -DVULKAN_HEADERS_INSTALL_DIR=/nix/store/ymglvisvvs3lnalfsaa3rf91wkj7xyzj-vulkan-headers-1.2.162.0 -DBUILD_WSI_WAYLAND_SUPPORT=ON
-- The C compiler identification is GNU 10.2.0
-- The CXX compiler identification is GNU 10.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/gk099cfff3s1g01adgvsn3957zabppvw-gcc-wrapper-10.2.0/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/gk099cfff3s1g01adgvsn3957zabppvw-gcc-wrapper-10.2.0/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found VulkanHeaders: /nix/store/ymglvisvvs3lnalfsaa3rf91wkj7xyzj-vulkan-headers-1.2.162.0/include
-- Found VulkanRegistry: /nix/store/ymglvisvvs3lnalfsaa3rf91wkj7xyzj-vulkan-headers-1.2.162.0/share/vulkan/registry
-- Detected Vulkan Version 1.2.162
-- Found PkgConfig: pkg-config (found version "0.29.2")
Package xdmcp was not found in the pkg-config search path.
Perhaps you should add the directory containing `xdmcp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xdmcp', required by 'xcb', not found
Package xdmcp was not found in the pkg-config search path.
Perhaps you should add the directory containing `xdmcp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xdmcp', required by 'xcb', not found
Package xdmcp was not found in the pkg-config search path.
Perhaps you should add the directory containing `xdmcp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xdmcp', required by 'xcb', not found
Package xdmcp was not found in the pkg-config search path.
Perhaps you should add the directory containing `xdmcp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xdmcp', required by 'xcb', not found
-- Found xcb: /nix/store/36ma3w2s70g7ipalv5xkz86yf745g1ca-libxcb-1.14-dev/include
Package expat was not found in the pkg-config search path.
Perhaps you should add the directory containing `expat.pc'
to the PKG_CONFIG_PATH environment variable
Package 'expat', required by 'fontconfig', not found
Package expat was not found in the pkg-config search path.
Perhaps you should add the directory containing `expat.pc'
to the PKG_CONFIG_PATH environment variable
Package 'expat', required by 'fontconfig', not found
Package expat was not found in the pkg-config search path.
Perhaps you should add the directory containing `expat.pc'
to the PKG_CONFIG_PATH environment variable
Package 'expat', required by 'fontconfig', not found
Package expat was not found in the pkg-config search path.
Perhaps you should add the directory containing `expat.pc'
to the PKG_CONFIG_PATH environment variable
Package 'expat', required by 'fontconfig', not found
-- Found X11: /nix/store/g34ahr3iz85vjjfdwpsfdwgy3537i5kp-xorgproto-2020.1/include
-- Looking for XOpenDisplay in /nix/store/6y53vmypx0lmd0r43sa8qsd026yqfsmz-libX11-1.7.0/lib/libX11.so;/nix/store/dm9k4ryj2dykk32z560a0mfnlf9c3pb8-libXext-1.3.4/lib/libXext.so
-- Looking for XOpenDisplay in /nix/store/6y53vmypx0lmd0r43sa8qsd026yqfsmz-libX11-1.7.0/lib/libX11.so;/nix/store/dm9k4ryj2dykk32z560a0mfnlf9c3pb8-libXext-1.3.4/lib/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libffi', required by 'wayland-client', not found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libffi', required by 'wayland-client', not found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libffi', required by 'wayland-client', not found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libffi', required by 'wayland-client', not found
-- Found WAYLAND_CLIENT: /nix/store/w6rq0kfag1yqb3pj0bi9g84nrv9nbckf-wayland-1.18.0/lib/libwayland-client.so
-- Found WAYLAND_SERVER: /nix/store/w6rq0kfag1yqb3pj0bi9g84nrv9nbckf-wayland-1.18.0/lib/libwayland-server.so
-- Found WAYLAND_EGL: /nix/store/w6rq0kfag1yqb3pj0bi9g84nrv9nbckf-wayland-1.18.0/lib/libwayland-egl.so
-- Found WAYLAND_CURSOR: /nix/store/w6rq0kfag1yqb3pj0bi9g84nrv9nbckf-wayland-1.18.0/lib/libwayland-cursor.so
-- Found WAYLAND: /nix/store/w6rq0kfag1yqb3pj0bi9g84nrv9nbckf-wayland-1.18.0/lib/libwayland-client.so;/nix/store/w6rq0kfag1yqb3pj0bi9g84nrv9nbckf-wayland-1.18.0/lib/libwayland-server.so;/nix/store/w6rq0kfag1yqb3pj0bi9g84nrv9nbckf-wayland-1.18.0/lib/libwayland-egl.so;/nix/store/w6rq0kfag1yqb3pj0bi9g84nrv9nbckf-wayland-1.18.0/lib/libwayland-cursor.so
-- Looking for secure_getenv
-- Looking for secure_getenv - found
-- Looking for __secure_getenv
-- Looking for __secure_getenv - not found
-- The ASM compiler identification is GNU
-- Found assembler: /nix/store/gk099cfff3s1g01adgvsn3957zabppvw-gcc-wrapper-10.2.0/bin/gcc
-- Looking for cet.h
-- Looking for cet.h - found
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING
    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_POLICY_DEFAULT_CMP0025


-- Build files have been written to: /build/source/build
cmake: enabled parallel building
building
build flags: -j16 -l16 SHELL=/nix/store/cwnwyy82wrq53820z6yg7869z8dl5s7g-bash-4.4-p23/bin/bash
Scanning dependencies of target asm_offset
[  7%] Building C object loader/CMakeFiles/asm_offset.dir/asm_offset.c.o
[ 14%] Linking C executable asm_offset
[ 14%] Built target asm_offset
Scanning dependencies of target loader_asm_gen_files
[ 21%] Generating gen_defines.asm
[ 21%] Built target loader_asm_gen_files
Scanning dependencies of target vulkan
[ 42%] Building C object loader/CMakeFiles/vulkan.dir/extension_manual.c.o
[ 50%] Building C object loader/CMakeFiles/vulkan.dir/debug_utils.c.o
[ 50%] Building C object loader/CMakeFiles/vulkan.dir/wsi.c.o
[ 50%] Building C object loader/CMakeFiles/vulkan.dir/cJSON.c.o
[ 64%] Building C object loader/CMakeFiles/vulkan.dir/loader.c.o
[ 64%] Building C object loader/CMakeFiles/vulkan.dir/murmurhash.c.o
[ 78%] Building C object loader/CMakeFiles/vulkan.dir/trampoline.c.o
[ 78%] Building C object loader/CMakeFiles/vulkan.dir/dev_ext_trampoline.c.o
[ 85%] Building ASM object loader/CMakeFiles/vulkan.dir/unknown_ext_chain_gas.S.o
[ 92%] Building C object loader/CMakeFiles/vulkan.dir/phys_dev_ext.c.o
/build/source/loader/loader.c: In function 'loader_get_json':
/build/source/loader/loader.c:2659:9: warning: ignoring return value of 'fread' declared with attribute 'warn_unused_result' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-result-Wunused-result8;;]
 2659 |         fread(buffer, 1, sizeof(buffer), file);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[100%] Linking C shared library libvulkan.so
[100%] Built target vulkan
installing
install flags: SHELL=/nix/store/cwnwyy82wrq53820z6yg7869z8dl5s7g-bash-4.4-p23/bin/bash install
[ 14%] Built target asm_offset
[ 21%] Built target loader_asm_gen_files
[100%] Built target vulkan
Install the project...
-- Install configuration: "Release"
-- Installing: /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/lib/pkgconfig/vulkan.pc
-- Installing: /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/lib/libvulkan.so.1.2.162
-- Installing: /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/lib/libvulkan.so.1
-- Installing: /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/lib/libvulkan.so
post-installation fixup
Moving /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/lib/pkgconfig to /nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev/lib/pkgconfig
rmdir: failed to remove '/nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/lib': Directory not empty
Patching '/nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev/lib/pkgconfig/vulkan.pc' includedir to output /nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev
shrinking RPATHs of ELF executables and libraries in /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0
shrinking /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/lib/libvulkan.so.1.2.162
strip is /nix/store/rqfgki7ck1bxqhk3hd7wziqhahjadfbj-binutils-2.35.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/lib
patching script interpreter paths in /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0
checking for references to /build/ in /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev
strip is /nix/store/rqfgki7ck1bxqhk3hd7wziqhahjadfbj-binutils-2.35.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev/lib
patching script interpreter paths in /nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev
checking for references to /build/ in /nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev...
running install tests
vulkan-headers include directory not found in pkg-config file
error: --- Error ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ nix-build
builder for '/nix/store/gxgpbskj0c8sj162bv6kwxy90rpna4jk-vulkan-loader-1.2.162.0.drv' failed with exit code 1; last 10 log lines:
  stripping (with command strip and flags -S) in /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0/lib
  patching script interpreter paths in /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0
  checking for references to /build/ in /nix/store/2qcldap66ypn8bj8ww4p5lx5mk3fvhk6-vulkan-loader-1.2.162.0...
  shrinking RPATHs of ELF executables and libraries in /nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev
  strip is /nix/store/rqfgki7ck1bxqhk3hd7wziqhahjadfbj-binutils-2.35.1/bin/strip
  stripping (with command strip and flags -S) in /nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev/lib
  patching script interpreter paths in /nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev
  checking for references to /build/ in /nix/store/30cv2gcv835gr71d06pl56icwv5daadv-vulkan-loader-1.2.162.0-dev...
  running install tests
  vulkan-headers include directory not found in pkg-config file

Slabity · 2021-02-01T20:11:59Z

Disregard... I'm just an idiot that forgot I overloaded the cmakeFlags for this specific package in my overlay a very long time ago.

ofborg bot requested a review from Ralith January 9, 2021 23:20

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 labels Jan 9, 2021

SuperSandro2000 approved these changes Jan 10, 2021

View reviewed changes

tadfisher mentioned this pull request Jan 21, 2021

gtk4: init at 4.0.2 #107405

Merged

10 tasks

jtojnar reviewed Jan 22, 2021

View reviewed changes

vulkan-loader: fix pkg-config include directory

0fe70e7

With the last update the pkg-config file was changed to cmake variables, which made substituteInPlace ineffective. Fixes NixOS#108766

B4dM4n force-pushed the vulkan-loader-include branch from 409a363 to 0fe70e7 Compare January 22, 2021 11:28

jtojnar merged commit b91b91c into NixOS:master Jan 22, 2021

B4dM4n deleted the vulkan-loader-include branch January 22, 2021 13:00

expipiplus1 mentioned this pull request Jan 22, 2021

vulkan-loader: pkgconfig description's include path points to missing directory #108766

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vulkan-loader: fix pkg-config include directory #108890

vulkan-loader: fix pkg-config include directory #108890

B4dM4n commented Jan 9, 2021

SuperSandro2000 commented Jan 10, 2021

Ralith commented Jan 10, 2021

SuperSandro2000 commented Jan 10, 2021

B4dM4n commented Jan 10, 2021

jtojnar Jan 22, 2021

B4dM4n Jan 22, 2021

B4dM4n commented Jan 22, 2021

jtojnar commented Jan 22, 2021

Slabity commented Feb 1, 2021

jtojnar commented Feb 1, 2021

Slabity commented Feb 1, 2021

Slabity commented Feb 1, 2021

vulkan-loader: fix pkg-config include directory #108890

vulkan-loader: fix pkg-config include directory #108890

Conversation

B4dM4n commented Jan 9, 2021

Motivation for this change

Things done

SuperSandro2000 commented Jan 10, 2021

Ralith commented Jan 10, 2021

SuperSandro2000 commented Jan 10, 2021

B4dM4n commented Jan 10, 2021

jtojnar Jan 22, 2021

Choose a reason for hiding this comment

B4dM4n Jan 22, 2021

Choose a reason for hiding this comment

B4dM4n commented Jan 22, 2021

jtojnar commented Jan 22, 2021

Slabity commented Feb 1, 2021

jtojnar commented Feb 1, 2021

Slabity commented Feb 1, 2021

Slabity commented Feb 1, 2021