Codechange: On regression failure, output the result in a file #8549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
When regression test fails, sometimes our basic diff is not the most usable output. Especially when you are adding more checks to regression test. Having the output in a file can allow use of more avanced tools to compare it with expected output.
Description
On failure simply save the output to a file.
But first I needed to add support for more output lines than expected.
And while in the area I moved the counter increment before diff output, so lines are numbered from 1.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.