Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conftest: 0.22.0 -> 0.23.0 #108845

Merged
merged 1 commit into from Jan 10, 2021
Merged

conftest: 0.22.0 -> 0.23.0 #108845

merged 1 commit into from Jan 10, 2021

Conversation

06kellyjac
Copy link
Member

Motivation for this change

Bump conftest version to 0.23.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 108845 run on x86_64-linux 1

4 packages built:
  • conftest
  • python37Packages.zha-quirks
  • python38Packages.zha-quirks
  • python39Packages.zha-quirks

@ofborg ofborg bot requested review from kalbasit and yurrriq January 9, 2021 11:00
@06kellyjac
Copy link
Member Author

This change also rebuilds zha-quirks, which was a surprise, as it depends on conftest. It'd be nice to see some conftest used to test other software in the wild but after looking into it I don't think it actually needs conftest.

See PR #108846

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108845 run on x86_64-darwin 1

1 package built:
  • conftest

@SuperSandro2000 SuperSandro2000 merged commit 14081f6 into NixOS:master Jan 10, 2021
@06kellyjac 06kellyjac deleted the conftest branch January 10, 2021 10:37
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108845 run on x86_64-linux 1

4 packages built:
  • conftest
  • python37Packages.zha-quirks
  • python38Packages.zha-quirks
  • python39Packages.zha-quirks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@yurrriq yurrriq Awaiting requested review from yurrriq

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@06kellyjac @SuperSandro2000