Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.*: Disable tests, nasc: Fix compilation with gcc10 #108925

Merged
merged 23 commits into from Jan 11, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jan 10, 2021

nasc: Fix compilation by using gcc9

This should be the last resort. Is it really not possible to stay with 10?

@SuperSandro2000
Copy link
Member Author

This should be the last resort. Is it really not possible to stay with 10?

/nix/store/kg2s3k77ifsyd59ac08mjmmjjmsvgsvg-gcc-10.2.0/include/c++/10.2.0/backward/backward_warning.h:32:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp]
   32 | #warning \
      |  ^~~~~~~
In file included from /nix/store/kg2s3k77ifsyd59ac08mjmmjjmsvgsvg-gcc-10.2.0/include/c++/10.2.0/ext/hash_map:64,
                 from ../subprojects/libqalculate/libqalculate/Calculator_p.h:30,
                 from ../subprojects/libqalculate/libqalculate/Calculator-definitions.cc:63:
/nix/store/kg2s3k77ifsyd59ac08mjmmjjmsvgsvg-gcc-10.2.0/include/c++/10.2.0/backward/hashtable.h: In instantiation of '__gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::size_type __gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::_M_bkt_num_key(const key_type&, std::size_t) const [with _Val = std::pair<Unit* const, bool>; _Key = Unit*; _HashFcn = __gnu_cxx::hash<Unit*>; _ExtractKey = std::_Select1st<std::pair<Unit* const, bool> >; _EqualKey = std::equal_to<Unit*>; _Alloc = std::allocator<bool>; __gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::size_type = long unsigned int; __gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::key_type = Unit*; std::size_t = long unsigned int]':
/nix/store/kg2s3k77ifsyd59ac08mjmmjjmsvgsvg-gcc-10.2.0/include/c++/10.2.0/backward/hashtable.h:596:30:   required from '__gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::size_type __gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::_M_bkt_num_key(const key_type&) const [with _Val = std::pair<Unit* const, bool>; _Key = Unit*; _HashFcn = __gnu_cxx::hash<Unit*>; _ExtractKey = std::_Select1st<std::pair<Unit* const, bool> >; _EqualKey = std::equal_to<Unit*>; _Alloc = std::allocator<bool>; __gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::size_type = long unsigned int; __gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::key_type = Unit*]'
/nix/store/kg2s3k77ifsyd59ac08mjmmjjmsvgsvg-gcc-10.2.0/include/c++/10.2.0/backward/hashtable.h:519:32:   required from '__gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::iterator __gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::find(const key_type&) [with _Val = std::pair<Unit* const, bool>; _Key = Unit*; _HashFcn = __gnu_cxx::hash<Unit*>; _ExtractKey = std::_Select1st<std::pair<Unit* const, bool> >; _EqualKey = std::equal_to<Unit*>; _Alloc = std::allocator<bool>; __gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::iterator = __gnu_cxx::hashtable<std::pair<Unit* const, bool>, Unit*, __gnu_cxx::hash<Unit*>, std::_Select1st<std::pair<Unit* const, bool> >, std::equal_to<Unit*>, std::allocator<bool> >::iterator; __gnu_cxx::hashtable<_Val, _Key, _HashFcn, _ExtractKey, _EqualKey, _Alloc>::key_type = Unit*]'
/nix/store/kg2s3k77ifsyd59ac08mjmmjjmsvgsvg-gcc-10.2.0/include/c++/10.2.0/ext/hash_map:213:26:   required from '__gnu_cxx::hash_map<_Key, _Tp, _HashFn, _EqualKey, _Alloc>::iterator __gnu_cxx::hash_map<_Key, _Tp, _HashFn, _EqualKey, _Alloc>::find(const key_type&) [with _Key = Unit*; _Tp = bool; _HashFn = __gnu_cxx::hash<Unit*>; _EqualKey = std::equal_to<Unit*>; _Alloc = std::allocator<bool>; __gnu_cxx::hash_map<_Key, _Tp, _HashFn, _EqualKey, _Alloc>::iterator = __gnu_cxx::hashtable<std::pair<Unit* const, bool>, Unit*, __gnu_cxx::hash<Unit*>, std::_Select1st<std::pair<Unit* const, bool> >, std::equal_to<Unit*>, std::allocator<bool> >::iterator; __gnu_cxx::hash_map<_Key, _Tp, _HashFn, _EqualKey, _Alloc>::key_type = Unit*]'
../subprojects/libqalculate/libqalculate/Calculator-definitions.cc:3432:23:   required from here
/nix/store/kg2s3k77ifsyd59ac08mjmmjjmsvgsvg-gcc-10.2.0/include/c++/10.2.0/backward/hashtable.h:604:23: error: no match for call to '(const hasher {aka const __gnu_cxx::hash<Unit*>}) (Unit* const&)'
  604 |       { return _M_hash(__key) % __n; }
      |                ~~~~~~~^~~~~~~
ninja: build stopped: subcommand failed.
builder for '/nix/store/bqmbrh4gbgvkdj5wr4x56pnyz6732gkm-nasc-0.7.5.drv' failed with exit code 1
error: build of '/nix/store/bqmbrh4gbgvkdj5wr4x56pnyz6732gkm-nasc-0.7.5.drv' failed

but I maybe have found a patch to fix this.

@SuperSandro2000 SuperSandro2000 changed the title pythonPackages.*: Disable tests,nasc: Fix compilation by using gcc9 pythonPackages.*: Disable tests,nasc: Fix compilation with gcc10 Jan 10, 2021
@SuperSandro2000 SuperSandro2000 changed the title pythonPackages.*: Disable tests,nasc: Fix compilation with gcc10 pythonPackages.*: Disable tests, nasc: Fix compilation with gcc10 Jan 10, 2021
@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108925 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • gnomecast
  • python39Packages.cliff
4 packages failed to build and are new build failures:
51 packages built:
  • afew
  • lieer (gmailieer)
  • python37Packages.geopandas
  • python37Packages.howdoi
  • python37Packages.keep
  • python37Packages.notmuch
  • python37Packages.notmuch2
  • python37Packages.osmnx
  • python37Packages.pyls-black
  • python37Packages.pyls-isort
  • python37Packages.pyls-mypy
  • python37Packages.pyls-spyder
  • python37Packages.python-jsonrpc-server
  • python37Packages.python-language-server
  • python37Packages.pytile
  • python37Packages.scrapy
  • python37Packages.scrapy-deltafetch
  • python37Packages.scrapy-fake-useragent
  • python37Packages.scrapy-splash
  • python37Packages.three-merge
  • python38Packages.cliff
  • python38Packages.geopandas
  • python38Packages.howdoi
  • python38Packages.keep
  • python38Packages.notmuch
  • python38Packages.notmuch2
  • python38Packages.osmnx
  • python38Packages.pyhaversion
  • python38Packages.pyls-black
  • python38Packages.pyls-isort
  • python38Packages.pyls-mypy
  • python38Packages.pyls-spyder
  • python38Packages.python-jsonrpc-server
  • python38Packages.python-language-server
  • python38Packages.pytile
  • python38Packages.scrapy
  • python38Packages.scrapy-deltafetch
  • python38Packages.scrapy-fake-useragent
  • python38Packages.scrapy-splash
  • python38Packages.three-merge
  • python39Packages.howdoi
  • python39Packages.keep
  • python39Packages.notmuch
  • python39Packages.notmuch2
  • python39Packages.pyhaversion
  • python39Packages.python-jsonrpc-server
  • python39Packages.scrapy
  • python39Packages.scrapy-deltafetch
  • python39Packages.scrapy-fake-useragent
  • python39Packages.scrapy-splash
  • python39Packages.three-merge

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.pyls-spyder:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.pyls-spyder:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jan 10, 2021

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108925 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python39Packages.cliff
6 packages failed to build and are new build failures:
56 packages built:
  • afew
  • alot
  • lieer (gmailieer)
  • gnomecast
  • nasc
  • python37Packages.alot
  • python37Packages.cliff
  • python37Packages.guestfs
  • python37Packages.howdoi
  • python37Packages.keep
  • python37Packages.notmuch
  • python37Packages.notmuch2
  • python37Packages.pyls-black
  • python37Packages.pyls-isort
  • python37Packages.pyls-mypy
  • python37Packages.pyls-spyder
  • python37Packages.python-jsonrpc-server
  • python37Packages.python-language-server
  • python37Packages.scrapy-deltafetch
  • python37Packages.scrapy-splash
  • python37Packages.spyder
  • python37Packages.swspotify
  • python37Packages.three-merge
  • python37Packages.xdot
  • python38Packages.cliff
  • python38Packages.guestfs
  • python38Packages.howdoi
  • python38Packages.keep
  • python38Packages.notmuch
  • python38Packages.notmuch2
  • python38Packages.pyhaversion
  • python38Packages.pyls-black
  • python38Packages.pyls-isort
  • python38Packages.pyls-mypy
  • python38Packages.pyls-spyder
  • python38Packages.python-jsonrpc-server
  • python38Packages.python-language-server
  • python38Packages.scrapy-deltafetch
  • python38Packages.scrapy-splash
  • spyder (python38Packages.spyder)
  • python38Packages.swspotify
  • python38Packages.three-merge
  • xdot (python38Packages.xdot)
  • python39Packages.alot
  • python39Packages.guestfs
  • python39Packages.howdoi
  • python39Packages.keep
  • python39Packages.notmuch
  • python39Packages.notmuch2
  • python39Packages.pyhaversion
  • python39Packages.python-jsonrpc-server
  • python39Packages.scrapy-deltafetch
  • python39Packages.scrapy-splash
  • python39Packages.swspotify
  • python39Packages.three-merge
  • python39Packages.xdot

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.pyls-spyder:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.pyls-spyder:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

optuna fails to build because mxnet does not build.

@SuperSandro2000 SuperSandro2000 force-pushed the fix-collection2 branch 2 times, most recently from 638d9eb to d2982d4 Compare January 10, 2021 12:31
@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108925 run on x86_64-darwin 1

7 packages marked as broken and skipped:
  • gnomecast
  • python37Packages.guestfs
  • python37Packages.optuna
  • python38Packages.guestfs
  • python38Packages.optuna
  • python39Packages.cliff
  • python39Packages.guestfs
1 package failed to build and are new build failure:
  • python37Packages.cliff: log was empty
54 packages built:
  • afew
  • lieer
  • python37Packages.geopandas
  • python37Packages.howdoi
  • python37Packages.keep
  • python37Packages.notmuch
  • python37Packages.notmuch2
  • python37Packages.osmnx
  • python37Packages.pyls-black
  • python37Packages.pyls-isort
  • python37Packages.pyls-mypy
  • python37Packages.pyls-spyder
  • python37Packages.python-jsonrpc-server
  • python37Packages.python-language-server
  • python37Packages.pytile
  • python37Packages.scrapy
  • python37Packages.scrapy-deltafetch
  • python37Packages.scrapy-fake-useragent
  • python37Packages.scrapy-splash
  • python37Packages.three-merge
  • python37Packages.worldengine
  • python38Packages.cliff
  • python38Packages.geopandas
  • python38Packages.howdoi
  • python38Packages.keep
  • python38Packages.notmuch
  • python38Packages.notmuch2
  • python38Packages.osmnx
  • python38Packages.pyhaversion
  • python38Packages.pyls-black
  • python38Packages.pyls-isort
  • python38Packages.pyls-mypy
  • python38Packages.pyls-spyder
  • python38Packages.python-jsonrpc-server
  • python38Packages.python-language-server
  • python38Packages.pytile
  • python38Packages.scrapy
  • python38Packages.scrapy-deltafetch
  • python38Packages.scrapy-fake-useragent
  • python38Packages.scrapy-splash
  • python38Packages.three-merge
  • worldengine-cli (python38Packages.worldengine)
  • python39Packages.howdoi
  • python39Packages.keep
  • python39Packages.notmuch
  • python39Packages.notmuch2
  • python39Packages.pyhaversion
  • python39Packages.python-jsonrpc-server
  • python39Packages.scrapy
  • python39Packages.scrapy-deltafetch
  • python39Packages.scrapy-fake-useragent
  • python39Packages.scrapy-splash
  • python39Packages.three-merge
  • python39Packages.worldengine

@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108925 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python39Packages.cliff
3 packages failed to build and are new build failures:
59 packages built:
  • afew
  • alot (python38Packages.alot)
  • gnomecast
  • lieer
  • nasc
  • python37Packages.alot
  • python37Packages.cliff
  • python37Packages.guestfs
  • python37Packages.howdoi
  • python37Packages.keep
  • python37Packages.notmuch
  • python37Packages.notmuch2
  • python37Packages.pyls-black
  • python37Packages.pyls-isort
  • python37Packages.pyls-mypy
  • python37Packages.pyls-spyder
  • python37Packages.python-jsonrpc-server
  • python37Packages.python-language-server
  • python37Packages.scrapy-deltafetch
  • python37Packages.scrapy-splash
  • python37Packages.spyder
  • python37Packages.swspotify
  • python37Packages.three-merge
  • python37Packages.worldengine
  • python37Packages.xdot
  • python38Packages.cliff
  • python38Packages.guestfs
  • python38Packages.howdoi
  • python38Packages.keep
  • python38Packages.notmuch
  • python38Packages.notmuch2
  • python38Packages.pyhaversion
  • python38Packages.pyls-black
  • python38Packages.pyls-isort
  • python38Packages.pyls-mypy
  • python38Packages.pyls-spyder
  • python38Packages.python-jsonrpc-server
  • python38Packages.python-language-server
  • python38Packages.scrapy-deltafetch
  • python38Packages.scrapy-splash
  • spyder (python38Packages.spyder)
  • python38Packages.swspotify
  • python38Packages.three-merge
  • worldengine-cli (python38Packages.worldengine)
  • xdot (python38Packages.xdot)
  • python39Packages.alot
  • python39Packages.guestfs
  • python39Packages.howdoi
  • python39Packages.keep
  • python39Packages.notmuch
  • python39Packages.notmuch2
  • python39Packages.pyhaversion
  • python39Packages.python-jsonrpc-server
  • python39Packages.scrapy-deltafetch
  • python39Packages.scrapy-splash
  • python39Packages.swspotify
  • python39Packages.three-merge
  • python39Packages.worldengine
  • python39Packages.xdot

@SuperSandro2000 SuperSandro2000 merged commit 91c8242 into NixOS:master Jan 11, 2021
@SuperSandro2000 SuperSandro2000 deleted the fix-collection2 branch January 11, 2021 18:26
@lukegb lukegb mentioned this pull request Jan 11, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants