New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: minor cleanup of packages maintained by siraben #108926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siraben
force-pushed
the
siraben-cleanup
branch
from
January 10, 2021 09:53
bca680a
to
a0b742c
Compare
siraben
force-pushed
the
siraben-cleanup
branch
from
January 10, 2021 10:01
a0b742c
to
929f82c
Compare
siraben
force-pushed
the
siraben-cleanup
branch
from
January 10, 2021 10:14
929f82c
to
d680dfc
Compare
Result of |
SuperSandro2000
approved these changes
Jan 10, 2021
@siraben can you rebase on master? |
siraben
force-pushed
the
siraben-cleanup
branch
from
February 21, 2021 12:24
d680dfc
to
3be4cfb
Compare
Rebased. |
ofborg
bot
added
10.rebuild-darwin: 0
and removed
2.status: merge conflict
10.rebuild-darwin: 1-10
labels
Feb 21, 2021
Result of |
davidak
approved these changes
Feb 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Remove occurrences of
stdenv.lib
.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)