Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sauerbraten: 2020-12-04 -> 2020-12-27 #108865

Merged
merged 1 commit into from Jan 9, 2021
Merged

sauerbraten: 2020-12-04 -> 2020-12-27 #108865

merged 1 commit into from Jan 9, 2021

Conversation

hax404
Copy link
Contributor

@hax404 hax404 commented Jan 9, 2021

Motivation for this change

Update; Version 2020-12-04 is not available on mirrors.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS: Played on x86_64 under sway/wayland; short test of Server
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests): no tests
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

andir
andir requested changes Jan 9, 2021
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that the commit has all the relevant information that you've given in the PR description.

@hax404
sauerbraten: 2020-12-04 -> 2020-12-27
aaf9cf6 
Bumped version because 2020-12-04 is not available on mirrors.
Tested server and client on NixOS x86_64 with sway/wayland.
Played some rounds with old and new maps on public servers.
@hax404
Copy link
Contributor Author

hax404 commented Jan 9, 2021

CC: @7c6f434c @ajs124

@hax404 hax404 requested a review from andir January 9, 2021 16:12
@ajs124 ajs124 merged commit 49c525e into NixOS:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hax404 @andir @ajs124